Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Paper] Migrate to emotion #24397

Merged
merged 4 commits into from
Jan 14, 2021
Merged

[Paper] Migrate to emotion #24397

merged 4 commits into from
Jan 14, 2021

Conversation

povilass
Copy link
Contributor

@mui-pr-bot
Copy link

mui-pr-bot commented Jan 13, 2021

@material-ui/core: parsed: +0.21% , gzip: +0.12%
@material-ui/lab: parsed: +0.20% , gzip: +0.09%

Details of bundle changes

Generated by 🚫 dangerJS against 4546392

@povilass
Copy link
Contributor Author

Demo code

@mnajdova mnajdova added the component: Paper This is the name of the generic UI component, not the React module! label Jan 13, 2021
Copy link
Member

@mnajdova mnajdova left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great, just a couple of minor comments :)

@mnajdova
Copy link
Member

For fixing the framer issue, feel free to add the sx prop in the ignored props for the Paper in the framerConfig.

diff --git a/framer/scripts/framerConfig.js b/framer/scripts/framerConfig.js
index fb02f439b6..526d4d294a 100644
--- a/framer/scripts/framerConfig.js
+++ b/framer/scripts/framerConfig.js
@@ -225,6 +225,7 @@ export const componentSettings = {
   },
   Paper: {
     ignoredProps: [
+      'sx',
       // FIXME: `Union`
       'variant',
     ],

@povilass
Copy link
Contributor Author

Yes, just look at that and did not get why this is happening with the framer xd.

@povilass
Copy link
Contributor Author

povilass commented Jan 13, 2021

Ok, great all seems to be ok now. I think after the release 5.0.0-alpha.23, I will commit AppBar, because I need Paper with emotion or if this will be merged to master.

@mnajdova
Copy link
Member

Demo code

In the future if you want to test showcase codesandbox with recent changes, you can open any example on this build, by following the netlify build - it will contain the codesandbox packages for this PR
image

I've created this demo with the recent changes - https://codesandbox.io/s/variants-material-demo-forked-qf81f?file=/demo.js

Ok, great all seems to be ok now. I think after the release 5.0.0-alpha.23, I will commit AppBar, because I need Paper with emotion or if this will be merged to master.

Sounds great!

Copy link
Member

@mnajdova mnajdova left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great! This is the first PR from the community for migrating a component to the new styling engine. 🙏 Thanks for your contribution!

@povilass
Copy link
Contributor Author

Yes I tried netlify in previous issues.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component: Paper This is the name of the generic UI component, not the React module!
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants