Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Breadcrumbs] Migrate to emotion #24522

Merged
merged 36 commits into from
Jan 25, 2021
Merged

[Breadcrumbs] Migrate to emotion #24522

merged 36 commits into from
Jan 25, 2021

Conversation

queengooborg
Copy link
Contributor

This PR migrates the Breadcrumbs component to the new emotion format as a part of #24405.

@mui-pr-bot
Copy link

mui-pr-bot commented Jan 20, 2021 •
edited
Loading

@material-ui/core: parsed: +0.29% , gzip: +0.20%

Details of bundle changes

Generated by 🚫 dangerJS against 153fc5c

@oliviertassinari oliviertassinari added the component: breadcrumbs This is the name of the generic UI component, not the React module! label Jan 20, 2021
@oliviertassinari oliviertassinari mentioned this pull request Jan 20, 2021
Closed
@github-actions github-actions bot mentioned this pull request Jan 20, 2021
Closed
@queengooborg
Copy link
Contributor Author

Looks like the failing test was probably a fluke? It's only failing on a specific Edgium version for an unrelated component.

mnajdova
mnajdova reviewed Jan 21, 2021
View reviewed changes
packages/material-ui/src/Breadcrumbs/Breadcrumbs.js Outdated Show resolved Hide resolved
packages/material-ui/src/Breadcrumbs/Breadcrumbs.js Outdated Show resolved Hide resolved
packages/material-ui/src/Breadcrumbs/Breadcrumbs.js Outdated Show resolved Hide resolved
packages/material-ui/src/Breadcrumbs/Breadcrumbs.js Outdated Show resolved Hide resolved
packages/material-ui/src/Breadcrumbs/Breadcrumbs.js Outdated Show resolved Hide resolved
packages/material-ui/src/Breadcrumbs/Breadcrumbs.js Outdated Show resolved Hide resolved
packages/material-ui/src/Breadcrumbs/Breadcrumbs.js Outdated Show resolved Hide resolved
packages/material-ui/src/Breadcrumbs/Breadcrumbs.js Outdated Show resolved Hide resolved
packages/material-ui/src/Breadcrumbs/Breadcrumbs.js Show resolved Hide resolved
packages/material-ui/src/Breadcrumbs/Breadcrumbs.test.js Outdated Show resolved Hide resolved
@github-actions github-actions bot added the PR: out-of-date The pull request has merge conflicts and can't be merged label Jan 21, 2021
@github-actions github-actions bot removed the PR: out-of-date The pull request has merge conflicts and can't be merged label Jan 21, 2021
@queengooborg
Copy link
Contributor Author

Just did a conversion of the BreadcrumbCollapsed component. Since it's a private, internal component, I noticed that the codebase was a bit different than normal -- hope I did it right!

queengooborg and others added 2 commits January 21, 2021 09:43
@queengooborg @oliviertassinari
Apply suggestions from code review
ff7d0c6 
Co-authored-by: Olivier Tassinari <olivier.tassinari@gmail.com>
@queengooborg @oliviertassinari
Update packages/material-ui/src/Breadcrumbs/BreadcrumbCollapsed.js
2f6d270 
Co-authored-by: Olivier Tassinari <olivier.tassinari@gmail.com>
queengooborg and others added 2 commits January 21, 2021 10:25
@queengooborg @mnajdova
Apply suggestions from code review
9c143e9 
Co-authored-by: Marija Najdova <mnajdova@gmail.com>
@queengooborg
Remove unused variable
6329cad
@queengooborg
Copy link
Contributor Author

Looks like Argos is seeing the different colors for the dark theme, which is to be expected.

@mnajdova
Copy link
Member

Looks like Argos is seeing the different colors for the dark theme, which is to be expected.

@oliviertassinari are we fine with this change?

@mnajdova mnajdova merged commit 27bbb5b into mui:next Jan 25, 2021
@queengooborg queengooborg deleted the migrate/Breadcrumbs branch January 25, 2021 07:46
natac13 pushed a commit to natac13/material-ui that referenced this pull request Jan 25, 2021
@queengooborg @natac13
[Breadcrumbs] Migrate to emotion (mui#24522)
614268e
eps1lon pushed a commit to eps1lon/material-ui that referenced this pull request Jan 26, 2021
@queengooborg @eps1lon
[Breadcrumbs] Migrate to emotion (mui#24522)
5663d84
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mnajdova mnajdova mnajdova approved these changes

@oliviertassinari oliviertassinari oliviertassinari approved these changes

Assignees

@mnajdova mnajdova

Labels
component: breadcrumbs This is the name of the generic UI component, not the React module!
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@queengooborg @mui-pr-bot @mnajdova @oliviertassinari