Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Backdrop] Migrate to emotion #24523

Merged
merged 5 commits into from
Jan 21, 2021
Merged

[Backdrop] Migrate to emotion #24523

merged 5 commits into from
Jan 21, 2021

Conversation

queengooborg
Copy link
Contributor

This PR migrates the Backdrop component to the new emotion format as a part of #24405.

@mui-pr-bot
Copy link

mui-pr-bot commented Jan 21, 2021 •
edited
Loading

@material-ui/core: parsed: +0.11% , gzip: +0.06%
@material-ui/lab: parsed: +0.09% , gzip: +0.08%

Details of bundle changes

Generated by 🚫 dangerJS against 94c36d4

mnajdova
mnajdova reviewed Jan 21, 2021
View reviewed changes
Copy link
Member

@mnajdova mnajdova left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a couple of comments otherwise looks good 👍

packages/material-ui/src/Backdrop/Backdrop.js Outdated Show resolved Hide resolved
packages/material-ui/src/Backdrop/Backdrop.test.js Outdated Show resolved Hide resolved
@mnajdova mnajdova mentioned this pull request Jan 21, 2021
Closed
@mnajdova mnajdova added the component: backdrop This is the name of the generic UI component, not the React module! label Jan 21, 2021
@queengooborg
Copy link
Contributor Author

Looks like the package build from CodeSandbox failed, seems like another fluke. Needs a quick rerun, and all should be good!

@github-actions github-actions bot added the PR: out-of-date The pull request has merge conflicts and can't be merged label Jan 21, 2021
@github-actions github-actions bot removed the PR: out-of-date The pull request has merge conflicts and can't be merged label Jan 21, 2021
@mnajdova mnajdova merged commit 302c303 into mui:next Jan 21, 2021
@queengooborg queengooborg deleted the migrate/Backdrop branch January 21, 2021 18:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mnajdova mnajdova mnajdova approved these changes

Assignees
No one assigned
Labels
component: backdrop This is the name of the generic UI component, not the React module!
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@queengooborg @mui-pr-bot @mnajdova