Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[List] Migrate ListItem to emotion #24543

Merged
merged 18 commits into from
Jan 25, 2021
Merged

[List] Migrate ListItem to emotion #24543

merged 18 commits into from
Jan 25, 2021

Conversation

xs9627
Copy link
Contributor

@xs9627 xs9627 commented Jan 22, 2021 •
edited by oliviertassinari
Loading

This PR migrates the ListItem component to the new emotion format as a part of #24405.

@mui-pr-bot
Copy link

mui-pr-bot commented Jan 22, 2021 •
edited
Loading

@material-ui/core: parsed: +0.26% , gzip: +0.22%

Details of bundle changes

Generated by 🚫 dangerJS against 618970f

mnajdova
mnajdova reviewed Jan 22, 2021
View reviewed changes
Copy link
Member

@mnajdova mnajdova left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Did a first round of review. Will do another one after these comments are resolved :)

mnajdova
mnajdova approved these changes Jan 22, 2021
View reviewed changes
Copy link
Member

@mnajdova mnajdova left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the contribution @xs9627

@oliviertassinari oliviertassinari mentioned this pull request Jan 22, 2021
Closed
@mnajdova mnajdova added the component: list This is the name of the generic UI component, not the React module! label Jan 22, 2021
@mnajdova mnajdova changed the title [ListItem] Migrate to emotion [List] Migrate ListItem to emotion Jan 22, 2021
@mnajdova mnajdova merged commit fbb0d9f into mui:next Jan 25, 2021
natac13 pushed a commit to natac13/material-ui that referenced this pull request Jan 25, 2021
@xs9627 @natac13
[List] Migrate ListItem to emotion (mui#24543)
e748cde
eps1lon pushed a commit to eps1lon/material-ui that referenced this pull request Jan 26, 2021
@xs9627 @eps1lon
[List] Migrate ListItem to emotion (mui#24543)
f3b0d0b
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@oliviertassinari oliviertassinari oliviertassinari approved these changes

@mnajdova mnajdova mnajdova approved these changes

Assignees

@mnajdova mnajdova

Labels
component: list This is the name of the generic UI component, not the React module!
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@xs9627 @mui-pr-bot @oliviertassinari @mnajdova