Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Switch] Migrate SwitchBase to emotion #24552

Merged
merged 12 commits into from
Jan 25, 2021
Merged

[Switch] Migrate SwitchBase to emotion #24552

merged 12 commits into from
Jan 25, 2021

Conversation

queengooborg
Copy link
Contributor

@queengooborg queengooborg commented Jan 22, 2021 •
edited
Loading

This PR migrates the SwitchBase component to the new emotion format as a part of #24405. Additionally, since we're here, this fixes a typo in the component's TypeScript definition for the classes (inpit -> input).

@mui-pr-bot
Copy link

mui-pr-bot commented Jan 22, 2021 •
edited
Loading

Details of bundle changes

Generated by 🚫 dangerJS against 3ea2b0f

@github-actions github-actions bot mentioned this pull request Jan 22, 2021
Closed
@oliviertassinari oliviertassinari added the component: switch This is the name of the generic UI component, not the React module! label Jan 22, 2021
@oliviertassinari oliviertassinari changed the title [SwitchBase] Migrate to emotion [Switch] Migrate SwitchBase to emotion Jan 22, 2021
@oliviertassinari oliviertassinari mentioned this pull request Jan 22, 2021
Closed
@queengooborg
Copy link
Contributor Author

queengooborg commented Jan 23, 2021 •
edited
Loading

@oliviertassinari Am I correct to assume that private components shouldn't have an overridesResolver function, a call to useThemeProps(), or the muiName variable defined in the describeConformanceV5() of the tests?

@oliviertassinari
Copy link
Member

Am I correct to assume that private components shouldn't have an overridesResolver function, a call to useThemeProps(), or the muiName variable defined in the describeConformanceV5() of the tests?

@vinyldarkscratch Yes, this sounds about right

@oliviertassinari oliviertassinari added the on hold There is a blocker, we need to wait label Jan 24, 2021
@oliviertassinari oliviertassinari removed the on hold There is a blocker, we need to wait label Jan 24, 2021
@oliviertassinari
Copy link
Member

oliviertassinari commented Jan 24, 2021 •
edited
Loading

I had to rebase because we needed IconButton to be migrated first.

@mnajdova mnajdova merged commit 877f62d into mui:next Jan 25, 2021
@queengooborg queengooborg deleted the migrate/SwitchBase branch January 25, 2021 07:02
natac13 pushed a commit to natac13/material-ui that referenced this pull request Jan 25, 2021
@queengooborg @natac13
[Switch] Migrate SwitchBase to emotion (mui#24552)
7faada0
eps1lon pushed a commit to eps1lon/material-ui that referenced this pull request Jan 26, 2021
@queengooborg @eps1lon
[Switch] Migrate SwitchBase to emotion (mui#24552)
cddb12b
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mnajdova mnajdova mnajdova approved these changes

@oliviertassinari oliviertassinari oliviertassinari approved these changes

Assignees

@mnajdova mnajdova

Labels
component: switch This is the name of the generic UI component, not the React module!
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@queengooborg @mui-pr-bot @oliviertassinari @mnajdova