Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[TextField] Migrate InputBase to emotion #24555

Merged
merged 18 commits into from
Jan 25, 2021
Merged

[TextField] Migrate InputBase to emotion #24555

merged 18 commits into from
Jan 25, 2021

Conversation

duganbrett
Copy link
Contributor

@duganbrett duganbrett commented Jan 22, 2021 •
edited by oliviertassinari
Loading

One chunk of #24405.

@brettdugan
[InputBase] Migrate to emotion
4438c45
@brettdugan
Fixed component name in inputBaseClasses and small code cleanup.
2ec8d70 
- Removed unrelated file changes.
- Added correct file change to api-docs
@mui-pr-bot
Copy link

mui-pr-bot commented Jan 22, 2021 •
edited
Loading

@material-ui/core: parsed: +0.34% , gzip: +0.31%

Details of bundle changes

Generated by 🚫 dangerJS against 1f71d56

@duganbrett
Copy link
Contributor Author

This one was marked as dependent on TextareaAutosize, however I though it would be okay since TextareaAutosize doesn't depend on JSS. Apologies if that's wrong.

@mnajdova
Copy link
Member

This one was marked as dependent on TextareaAutosize, however I though it would be okay since TextareaAutosize doesn't depend on JSS. Apologies if that's wrong.

Ah correct I didn’t noticed that the styles are directly applied.

@mnajdova mnajdova added component: list This is the name of the generic UI component, not the React module! and removed component: list This is the name of the generic UI component, not the React module! labels Jan 23, 2021
@oliviertassinari oliviertassinari added the component: text field This is the name of the generic UI component, not the React module! label Jan 23, 2021
@oliviertassinari oliviertassinari changed the title [InputBase] Migrate to emotion [TextField] Migrate InputBase to emotion Jan 23, 2021
@oliviertassinari oliviertassinari mentioned this pull request Jan 23, 2021
Closed
@mnajdova mnajdova merged commit cc6a9d8 into mui:next Jan 25, 2021
natac13 pushed a commit to natac13/material-ui that referenced this pull request Jan 25, 2021
@duganbrett @natac13
[TextField] Migrate InputBase to emotion (mui#24555)
c4e20dd
eps1lon pushed a commit to eps1lon/material-ui that referenced this pull request Jan 26, 2021
@duganbrett @eps1lon
[TextField] Migrate InputBase to emotion (mui#24555)
8fa3883
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@oliviertassinari oliviertassinari oliviertassinari approved these changes

@mnajdova mnajdova mnajdova approved these changes

Assignees

@mnajdova mnajdova

Labels
component: text field This is the name of the generic UI component, not the React module!
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@duganbrett @mui-pr-bot @mnajdova @oliviertassinari @brettdugan