[TextField] Migrate FilledInput to emotion #24634
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mnajdova
commented
Jan 26, 2021
|
@material-ui/core: parsed: +0.26% , gzip: +0.30% |
mnajdova
changed the title
1 task
…ajdova/material-ui into feat/filled-input-alternative
oliviertassinari
approved these changes
Jan 26, 2021
mnajdova
changed the title
mnajdova
changed the title
|
@oliviertassinari would be nice before merging if you can take a look on the solution for these argos differences that we had - https://www.argos-ci.com/mui-org/material-ui/builds/7319 Here is the commit 316c968
Let me know what you think. |
|
@mnajdova OK, I'm on it. |
oliviertassinari
added
the
component: text field
|
@mnajdova I have fixed two visual regressions that were reported by Argos. For 1. I can't see the impact. For 2. I think that we can try without, and see if it fly. |
oliviertassinari
approved these changes
Jan 26, 2021
duganbrett
reviewed
Jan 26, 2021
1 task
mnajdova
commented
Jan 27, 2021
1 task
xs9627
added a commit
to xs9627/material-ui
that referenced
this pull request
Jan 27, 2021
* next: (34 commits) [Tab] Migrate to emotion (mui#24651) [TextField] Migrate Input component to emotion (mui#24638) [ImageList] Migrate ImageListItemBar to emotion (mui#24632) [CircularProgress] Migrate to emotion (mui#24622) [DataTable] Add example in docs for data table (mui#24428) [Card] Migrate CardActionArea to emotion (mui#24636) [core] Fix `next` using stale pages (mui#24635) [List] Migrate ListItemIcon to emotion (mui#24630) [ClickAwayListener] Fix `children` and `onClickAway` types (mui#24565) [docs] Include in docs directive to silence `eslint` erroneous warning (mui#24644) [Fab] Migrate to emotion (mui#24618) [TextField] Migrate FilledInput to emotion (mui#24634) [Card] Migrate CardHeader to emotion (mui#24626) [Card] Migrate CardMedia to emotion (mui#24625) [ImageList] Migrate ImageListItem to emotion (mui#24619) [website] Add vision block (mui#24603) [docs] Add sorting section (mui#24637) [TextField] Prepare removal of labelWidth prop (mui#24595) [Dialog] Migrate DialogTitle to emotion (mui#24623) [ImageList] Migrate to emotion (mui#24615) ...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Alternative of #24617 Migrates FilledInput to emotion and adds the
componentsandcomponetnsPropsprops on theInpuBasecomponent.