Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Autocomplete] Migrate to emotion #24696

Merged
merged 16 commits into from
Feb 15, 2021
Merged

Conversation

natac13
Copy link
Contributor

@natac13 natac13 commented Jan 29, 2021

#24405

Have some failing tests due to:

Using first-child instead of first-of-type. Says first-child not save in SSR. Just not sure how you would like this handled.

The other is to do with the icon classes test. hasPopupIcon and hasClearIcon

@mui-pr-bot
Copy link

mui-pr-bot commented Jan 29, 2021

@material-ui/core: parsed: +0.61% , gzip: +0.47%
@material-ui/lab: parsed: +0.69% , gzip: +0.69%

Details of bundle changes

Generated by 🚫 dangerJS against 1cc9ddf

@oliviertassinari oliviertassinari added the component: autocomplete This is the name of the generic UI component, not the React module! label Jan 29, 2021
@oliviertassinari oliviertassinari self-assigned this Feb 14, 2021
@oliviertassinari oliviertassinari merged commit a1e651f into mui:next Feb 15, 2021
@oliviertassinari
Copy link
Member

@natac13 A hard one!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component: autocomplete This is the name of the generic UI component, not the React module!
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants