[CssBaseline] Make dark mode scrollbar overrides an optional function #24780
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
oliviertassinari
changed the title
oliviertassinari
force-pushed
the
optional-dark-mode-scrollbar
branch
2 times, most recently
from
f9d5638 to
9929999
Compare
oliviertassinari
force-pushed
the
optional-dark-mode-scrollbar
branch
from
9929999 to
58dffa6
Compare
oliviertassinari
approved these changes
Feb 7, 2021
mbrookes
reviewed
Feb 7, 2021
| components: { | ||
| MuiCssBaseline: { | ||
| styleOverrides: { | ||
| body: paletteMode === 'dark' ? darkScrollbar() : null, |
There was a problem hiding this comment.
Are you saying you would rather not see it used in the documentation? Most of the audience is on Windows/Linux. Maybe I'm not troubled by the behavior because I have my scrollbar configured on macOS to behave like on Windows/Linux.
There was a problem hiding this comment.
Not personally, but I get it, which is why I didn't comment further.
mbrookes
requested changes
Feb 7, 2021
Co-authored-by: Matt <github@nospam.33m.co>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #23520