-
-
Notifications
You must be signed in to change notification settings - Fork 32.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[docs] fixed webpack config for production #2492
Conversation
Also, we could include 'npm run build' in docs as an additional check in Travis CI. |
@igorbt Thanks for doing this. but since i'm no expert on the deployment, I'll this to @oliviertassinari, and I really like your idea about having aother file for the common parts, but I'm not so familiar with how webpack works yet, and I'm new around this library 😁
I think it's a great idea. |
I think that it's a great idea to avoid code duplication. |
Perfect idea! I like that 👍 👍 |
@igorbt I confirm, it was borken before and it's working now. Thanks! |
[docs] fixed webpack config for production
@igorbt Thanks a bunch for getting rid of this bug. |
I had errors while tying to run 'npm run build' in docs. I realized that webpack-dev-server.config.js had some changes that were missing in webpack-production.config.js. BTW, maybe a better idea would be to have the common parts of these 2 extracted in a separate file so that they will not get un-synced in the future.