Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[docs] fixed webpack config for production #2492

Merged
merged 1 commit into from
Dec 13, 2015

Conversation

igorbt
Copy link
Contributor

@igorbt igorbt commented Dec 12, 2015

I had errors while tying to run 'npm run build' in docs. I realized that webpack-dev-server.config.js had some changes that were missing in webpack-production.config.js. BTW, maybe a better idea would be to have the common parts of these 2 extracted in a separate file so that they will not get un-synced in the future.

@igorbt
Copy link
Contributor Author

igorbt commented Dec 12, 2015

Also, we could include 'npm run build' in docs as an additional check in Travis CI.

@alitaheri
Copy link
Member

@igorbt Thanks for doing this. but since i'm no expert on the deployment, I'll this to @oliviertassinari, and I really like your idea about having aother file for the common parts, but I'm not so familiar with how webpack works yet, and I'm new around this library 😁

we could include 'npm run build' in docs as an additional check in Travis CI.

I think it's a great idea.

@oliviertassinari
Copy link
Member

maybe a better idea would be to have the common parts of these 2 extracted in a separate file

I think that it's a great idea to avoid code duplication.
Another way would be to have only one config file and passing a production / development parameter
(This is what I'm doing personally for my projets).

@alitaheri
Copy link
Member

Another way would be to have only one config file and passing a production / development parameter.

Perfect idea! I like that 👍 👍

@oliviertassinari
Copy link
Member

@igorbt I confirm, it was borken before and it's working now. Thanks!

oliviertassinari added a commit that referenced this pull request Dec 13, 2015
[docs] fixed webpack config for production
@oliviertassinari oliviertassinari merged commit 46ceed1 into mui:master Dec 13, 2015
@alitaheri
Copy link
Member

@igorbt Thanks a bunch for getting rid of this bug.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
docs Improvements or additions to the documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants