Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create deprecatedExport utility function #2519

Merged
merged 1 commit into from
Dec 14, 2015

Conversation

newoga
Copy link
Contributor

@newoga newoga commented Dec 14, 2015

This idea was introduced in #2476. Also related to #1793.

This function will assist us with deprecating modules with "kebab-case" names in favor of more React compatible "PascalCase" names (for example TextField.jsx instead of text-field.jsx).

It would be used like this:

/* material-ui/lib/text-field.jsx */

import TextField from './TextField'; // new location
import deprecatedExport from './utils/deprecatedExport';

export default deprecatedExport(TextField, 'material-ui/lib/text-field', 'material-ui/lib/TextField');

@oliviertassinari
Copy link
Member

@newoga I'm ok with this 😄
@subjectix I guess that we should wait 0.14.0 before deprecating the current location of component.

@alitaheri
Copy link
Member

@oliviertassinari Yeah this is gonna be a huge change! and must be eased into. let's just merge this for now. And wait for the right time before dropping the change :D

@newoga
Copy link
Contributor Author

newoga commented Dec 14, 2015

Sounds good to me! :)

oliviertassinari added a commit that referenced this pull request Dec 14, 2015
Create deprecatedExport utility function
@oliviertassinari oliviertassinari merged commit f5929b0 into mui:master Dec 14, 2015
@newoga newoga deleted the deprecated-export branch December 15, 2015 03:33
@zannager zannager added the component: text field This is the name of the generic UI component, not the React module! label Mar 16, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component: text field This is the name of the generic UI component, not the React module!
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants