Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Doc] Add menu items to select fields documentation #2542

Conversation

panozzaj
Copy link

I looked at the examples online and had a tough time understanding what the format of menuItems was. I dug into the source of the page that rendered that example and figured out what the value should be. Then I added this code where it would be seen. I'm not sure if this is the right format but thought it might be a step in the right direction.

I looked at the examples online and had a tough time understanding what
the format of `menuItems` was. I dug into the source of the page that
rendered that example and figured out what the value should be. Then I
added this code where it would be seen. I'm not sure if this is the
right format but thought it might be a step in the right direction.
@alitaheri
Copy link
Member

@panozzaj Sorry to say this, but the menuItems are going to be deprecated. 😅 😅
Besides, the documentations are under going major changes. In the new standard we won't be using text files, but rather use the source code of each example as a way to demonstrate it. see the discussion at #2433

@oliviertassinari oliviertassinari added the PR: needs revision The pull request can't be merged. More details is available on the code review or fails in the CI label Dec 16, 2015
@oliviertassinari
Copy link
Member

I looked at the examples online and had a tough time understanding what the format of menuItems was

@panozzaj I confirm, that exactly what we want to address with the documentation migration.
Thanks for the effort. I'm gonna close this PR.

@panozzaj
Copy link
Author

No worries, just took a couple of minutes. Thanks for all of the great
work, it is helping our project be better!

Sent from my phone
On Dec 16, 2015 4:59 AM, "Olivier Tassinari" notifications@github.com
wrote:

I looked at the examples online and had a tough time understanding what
the format of menuItems was

@panozzaj https://github.com/panozzaj I confirm, that exactly what we
whent to address with the doc migration.
Thanks for the effort. I'm gonna close this PR.


Reply to this email directly or view it on GitHub
#2542 (comment)
.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
PR: needs revision The pull request can't be merged. More details is available on the code review or fails in the CI
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants