Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[docs] Fix dynamic global styles #25690

Merged
merged 16 commits into from
May 7, 2021
Merged

[docs] Fix dynamic global styles #25690

merged 16 commits into from
May 7, 2021

Conversation

mnajdova
Copy link
Member

@mnajdova mnajdova commented Apr 9, 2021 •
edited
Loading

Bumps @emotion/react, @emotion/server & @emotion/cache to 11.4.0, to leverage the new critical extract method (emotion-js/emotion#2334).

Preview: https://deploy-preview-25690--material-ui.netlify.app/

Fix #25458

@mui-pr-bot
Copy link

mui-pr-bot commented Apr 9, 2021 •
edited
Loading

Details of bundle changes

Generated by 🚫 dangerJS against 1399e16

@mnajdova mnajdova mentioned this pull request Apr 9, 2021
Merged
4 tasks
@mnajdova mnajdova marked this pull request as draft April 9, 2021 23:29
@github-actions github-actions bot mentioned this pull request Apr 9, 2021
Closed
@mnajdova

This comment has been minimized.

Sign in to view
@oliviertassinari

This comment has been minimized.

Sign in to view
@mnajdova mnajdova mentioned this pull request Apr 21, 2021
Merged
@oliviertassinari oliviertassinari mentioned this pull request Apr 21, 2021
Closed
2 tasks
@github-actions github-actions bot added the PR: out-of-date The pull request has merge conflicts and can't be merged label Apr 22, 2021
@github-actions github-actions bot removed the PR: out-of-date The pull request has merge conflicts and can't be merged label Apr 22, 2021
This was referenced Apr 22, 2021
Merged
Closed
@github-actions github-actions bot added the PR: out-of-date The pull request has merge conflicts and can't be merged label Apr 25, 2021
@mnajdova
Copy link
Member Author

Closing, will reopen when the fix is relased.

@mnajdova mnajdova closed this Apr 30, 2021
@mnajdova mnajdova changed the title [DO NOT MERGE] Test SSR fix on emotion [docs] Fix dynamic global styles May 7, 2021
@mnajdova mnajdova reopened this May 7, 2021
@mnajdova mnajdova marked this pull request as ready for review May 7, 2021 08:06
@github-actions github-actions bot removed the PR: out-of-date The pull request has merge conflicts and can't be merged label May 7, 2021
@github-actions github-actions bot mentioned this pull request May 7, 2021
Closed
eps1lon
eps1lon approved these changes May 7, 2021
View reviewed changes
Copy link
Member

@eps1lon eps1lon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I can read the docs again 🥳

eps1lon
eps1lon reviewed May 7, 2021
View reviewed changes
Copy link
Member

@eps1lon eps1lon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

question: Does our nextjs example need to be adjusted as well or did this just affect our docs?

@oliviertassinari oliviertassinari added bug 🐛 Something doesn't work docs Improvements or additions to the documentation labels May 7, 2021
@mnajdova
Copy link
Member Author

mnajdova commented May 7, 2021

question: Does our nextjs example need to be adjusted as well or did this just affect our docs?

They need to, I am already on it :)

oliviertassinari
oliviertassinari approved these changes May 7, 2021
View reviewed changes
Copy link
Member

@oliviertassinari oliviertassinari left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Agree with Sebastian, we should fix the examples, but otherwise, it delivers. Well done!

@mnajdova mnajdova merged commit e51737a into mui:next May 7, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@eps1lon eps1lon eps1lon approved these changes

@oliviertassinari oliviertassinari oliviertassinari approved these changes

Assignees
No one assigned
Labels
bug 🐛 Something doesn't work docs Improvements or additions to the documentation
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

CssBaseline styles for body are duplicated in the next.js example
4 participants
@mnajdova @mui-pr-bot @oliviertassinari @eps1lon