[Timeline] Migrate TimelineOppositeContent to emotion #25816
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@material-ui/lab: parsed: +0.14% , gzip: +0.04% |
vicasas
commented
Apr 17, 2021
packages/material-ui-lab/src/TimelineOppositeContent/timelineOppositeContentClasses.js
Show resolved
Hide resolved
packages/material-ui-lab/src/TimelineOppositeContent/TimelineOppositeContent.js
Outdated
Show resolved
Hide resolved
oliviertassinari
added
the
component: timeline
vicasas
commented
Apr 17, 2021
packages/material-ui-lab/src/TimelineOppositeContent/TimelineOppositeContent.js
Show resolved
Hide resolved
oliviertassinari
approved these changes
Apr 17, 2021
…ttps://github.com/vicasas/material-ui into feature/migrate-timeline-opposite-demo-to-emotion
mnajdova
reviewed
Apr 19, 2021
| const { classes, className, ...other } = props; | ||
| const TimelineOppositeContent = React.forwardRef(function TimelineOppositeContent(inProps, ref) { | ||
| const props = useThemeProps({ props: inProps, name: 'MuiTimelineOppositeContent' }); | ||
| const { className, ...other } = props; | ||
|
|
||
| const { align = 'left' } = React.useContext(TimelineContext); | ||
| const { classes: contextClasses = {} } = React.useContext(TimelineItemContext); |
There was a problem hiding this comment.
We won't be needing this after #25822 (review) No preference on the other of how there are merged as long as we release them all at once.
There was a problem hiding this comment.
Let's merge this one and we can actually do the update in #25822 (review)
mnajdova
approved these changes
Apr 19, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
One of #24405