Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[core] Fix various too wide classes types #25917

Merged
merged 7 commits into from
Apr 25, 2021

Conversation

eps1lon
Copy link
Member

@eps1lon eps1lon commented Apr 23, 2021

These classes had no effect at runtime. They're still accepted by the type-checker (excess properties are accept in most cases anyway) but at least they're no longer suggested by IntelliSense.

Components affected:

  • AppBar
  • Card
  • Link
  • LoadingButton
  • MenuItem

Noticed during #25754

@eps1lon eps1lon added bug 🐛 Something doesn't work package: material-ui Specific to @mui/material typescript labels Apr 23, 2021
@mui-pr-bot
Copy link

mui-pr-bot commented Apr 23, 2021

No bundle size changes

Generated by 🚫 dangerJS against 30cd71e

@eps1lon eps1lon changed the title [core] Fix various ] [core] Fix various too wide classes types Apr 23, 2021
@eps1lon eps1lon marked this pull request as ready for review April 24, 2021 11:25
@eps1lon
Copy link
Member Author

eps1lon commented Apr 25, 2021

Might not have caught all instances of this issue but let's get this in to gain clarity.

@eps1lon eps1lon merged commit 184d28f into mui:next Apr 25, 2021
@eps1lon eps1lon deleted the fix/too-wide-classes branch April 25, 2021 18:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug 🐛 Something doesn't work package: material-ui Specific to @mui/material typescript
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants