[docs] Avoid extracting classes twice #25973
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@eps1lon Should I update this PR to only salvage the fix on |
|
@eps1lon Updated. My aim is to get the .json generated so that once we migrate to emotion, we can notice regressions. |
eps1lon
approved these changes
Apr 27, 2021
|
@eps1lon What do you mean, will we kill the .json file for the docs? :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
updateStylesDefinition()is always called twice but once is enough. I have noticed this inefficiency when diving into #25928 (comment). I didn't benchmark the performance win.I have used this as an opportunity to isolate what's for legacy components (JSS), so we can more easily remove the code later on.Fix
DateRangePickerDayclasses extraction.