Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[docs] Add accessibility section to Badges #26009

Merged
merged 5 commits into from
May 11, 2021
Merged

[docs] Add accessibility section to Badges #26009

merged 5 commits into from
May 11, 2021

Conversation

likitarai1
Copy link
Contributor

@likitarai1 likitarai1 commented Apr 28, 2021 •
edited by oliviertassinari
Loading

@mui-pr-bot
Copy link

mui-pr-bot commented Apr 28, 2021 •
edited
Loading

No bundle size changes

Generated by 🚫 dangerJS against 7349e2a

@likitarai1 likitarai1 changed the title [docs] Add accessibility section to Badges #22070 [docs] Add accessibility section to Badges Apr 28, 2021
eps1lon
eps1lon requested changes Apr 28, 2021
View reviewed changes
docs/src/pages/components/badges/AccessibleBadges.js Outdated Show resolved Hide resolved
docs/src/pages/components/badges/AccessibleBadges.js Outdated Show resolved Hide resolved
docs/src/pages/components/badges/badges.md Outdated Show resolved Hide resolved
docs/src/pages/components/badges/badges.md Outdated Show resolved Hide resolved
@oliviertassinari oliviertassinari added accessibility a11y component: badge This is the name of the generic UI component, not the React module! labels Apr 28, 2021
@github-actions github-actions bot mentioned this pull request May 2, 2021
Closed
oliviertassinari
oliviertassinari approved these changes May 2, 2021
View reviewed changes
Copy link
Member

@oliviertassinari oliviertassinari left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have tried to simplify the content of the accessibility section, to go to its essence. I have also used the opportunity to polish the other demos on the page.

@eps1lon
Copy link
Member

eps1lon commented May 11, 2021

Not ideal but at least we have it documented.

@eps1lon eps1lon merged commit f6461b5 into mui:next May 11, 2021
@eps1lon
Copy link
Member

eps1lon commented May 11, 2021

@likitarai1 Thanks!

@likitarai1 likitarai1 deleted the docs/accessibility-badges branch May 31, 2021 12:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@oliviertassinari oliviertassinari oliviertassinari approved these changes

@eps1lon eps1lon eps1lon approved these changes

Assignees
No one assigned
Labels
accessibility a11y component: badge This is the name of the generic UI component, not the React module!
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Badge] Improve accessibility
4 participants
@likitarai1 @mui-pr-bot @eps1lon @oliviertassinari