Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[pickers] Migrate MonthPicker to emotion #26025

Merged
merged 10 commits into from
May 11, 2021
Merged

[pickers] Migrate MonthPicker to emotion #26025

merged 10 commits into from
May 11, 2021

Conversation

siriwatknp
Copy link
Member

@siriwatknp siriwatknp commented Apr 28, 2021 •
edited by oliviertassinari
Loading

One of #24405

@siriwatknp siriwatknp mentioned this pull request Apr 28, 2021
Closed
@mui-pr-bot
Copy link

mui-pr-bot commented Apr 28, 2021 •
edited
Loading

Details of bundle changes (experimental)

@material-ui/lab: parsed: +0.12% , gzip: +0.09%

Generated by 🚫 dangerJS against c8fce89

@oliviertassinari oliviertassinari added the component: pickers This is the name of the generic UI component, not the React module! label Apr 28, 2021
@oliviertassinari oliviertassinari changed the title [Pickers] Migrate MonthPicker to emotion [pickers] Migrate MonthPicker to emotion Apr 28, 2021
@github-actions github-actions bot mentioned this pull request May 2, 2021
Closed
@siriwatknp siriwatknp requested a review from mnajdova May 10, 2021 13:19
@siriwatknp
Copy link
Member Author

@mnajdova This is not an internal component so I think it make sense to expose sx props and classesUtility

@mnajdova mnajdova requested a review from eps1lon May 10, 2021 14:01
@eps1lon eps1lon removed their request for review May 11, 2021 06:42
@siriwatknp siriwatknp merged commit 2351cfa into mui:next May 11, 2021
@siriwatknp siriwatknp deleted the month-picker-emotion branch May 11, 2021 11:28
@oliviertassinari
Copy link
Member

@siriwatknp If you could tick the checkbox in #24405 once you merge the migrated component, it would be 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mnajdova mnajdova mnajdova approved these changes

Assignees
No one assigned
Labels
component: pickers This is the name of the generic UI component, not the React module!
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@siriwatknp @mui-pr-bot @oliviertassinari @mnajdova @eps1lon