-
-
Notifications
You must be signed in to change notification settings - Fork 32.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Select] Remove labelWidth
prop
#26026
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
@material-ui/core: parsed: -0.10% 😍, gzip: -0.09% 😍 |
oliviertassinari
requested changes
Apr 28, 2021
oliviertassinari
added
breaking change
component: select
This is the name of the generic UI component, not the React module!
labels
Apr 28, 2021
m4theushw
changed the title
[TextField][Select] Remove
[Select] Remove Apr 28, 2021
labelWidth
proplabelWidth
prop
oliviertassinari
approved these changes
Apr 29, 2021
@m4theushw Well done! |
2 tasks
42 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
breaking change
component: select
This is the name of the generic UI component, not the React module!
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Breaking change
[Select] The
labelWidth
prop was removed. Thelabel
prop now fulfills the same purpose, using CSS layout instead of JavaScript measurement to render the gap in the outlined. The TextField already handles it by default.Part of #20012
Closes #22799
Preview: https://deploy-preview-26026--material-ui.netlify.app/components/text-fields/