Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Select] Open popup below button #26200

Merged
merged 3 commits into from
May 31, 2021
Merged

[Select] Open popup below button #26200

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
ac458f2
[Select] Open below
oliviertassinari May 8, 2021
7f6098c
[Autocomplete] Reduce textbox <> popup gap
oliviertassinari May 24, 2021
30ffba2
Update packages/material-ui/src/Autocomplete/Autocomplete.js
oliviertassinari May 27, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 0 additions & 1 deletion packages/material-ui/src/Autocomplete/Autocomplete.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -254,7 +254,6 @@ const AutocompletePaper = experimentalStyled(Paper, {
/* Styles applied to the Paper component. */
...theme.typography.body1,
overflow: 'auto',
margin: '4px 0',
}));

const AutocompleteLoading = experimentalStyled('div', {
Expand Down
8 changes: 8 additions & 0 deletions packages/material-ui/src/Select/SelectInput.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -495,6 +495,14 @@ const SelectInput = React.forwardRef(function SelectInput(props, ref) {
anchorEl={displayNode}
open={open}
onClose={handleClose}
anchorOrigin={{
vertical: 'bottom',
horizontal: 'center',
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why "center"? It makes our <Select /> looks like this:

image

}}
transformOrigin={{
vertical: 'top',
horizontal: 'center',
}}
{...MenuProps}
MenuListProps={{
'aria-labelledby': labelId,
Expand Down