Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Slider] Center value label for disabled slider #26257

Merged

Conversation

davidfdriscoll
Copy link
Contributor

@davidfdriscoll davidfdriscoll commented May 11, 2021

This PR correctly centers a value label for a disabled slider, resolving this issue, by removing a fix for IE 11. It also removes the same fix from the customized slider demos and adds a simple test for a disabled slider with an active value label.

Closes #19329

Screenshot 2021-05-15 at 14 14 00

<Slider
  color="success"
  value={value}
  step={10}
  marks
  valueLabelDisplay="auto"
  onChange={handleChange}
  aria-labelledby="continuous-slider"
/>

@mui-pr-bot
Copy link

mui-pr-bot commented May 11, 2021

Details of bundle changes (experimental)

Generated by 🚫 dangerJS against 0d12cc3

@oliviertassinari oliviertassinari added bug 🐛 Something doesn't work component: slider This is the name of the generic UI component, not the React module! labels May 11, 2021
@oliviertassinari oliviertassinari force-pushed the value-label-on-disabled-slider branch from 208a589 to 0d12cc3 Compare May 16, 2021 11:06
@oliviertassinari oliviertassinari merged commit 58ef26b into mui:next May 16, 2021
@davidfdriscoll davidfdriscoll deleted the value-label-on-disabled-slider branch May 16, 2021 12:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug 🐛 Something doesn't work component: slider This is the name of the generic UI component, not the React module!
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Slider] Value label position if disabled
3 participants