Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Dialog] Flatten DialogTitle DOM structure, remove disableTypography #26323

Merged
merged 6 commits into from
May 31, 2021
Merged

[Dialog] Flatten DialogTitle DOM structure, remove disableTypography #26323

merged 6 commits into from
May 31, 2021

Conversation

eps1lon
Copy link
Member

@eps1lon eps1lon commented May 16, 2021 •
edited by oliviertassinari
Loading

Breaking changes

  • [Dialog] Flatten DialogTitle DOM structure, remove disableTypography prop

    -<DialogTitle disableTypography>
-  <Typography variant="h4" component="h2">
+<DialogTitle>
+  <Typography variant="h4" component="span">
     My header
   </Typography>

Quickly testing. The goal of #19696 was to make the impl and behavior simpler. But the discussion in #19696 goes in the opposite direction right now.

https://deploy-preview-26323--material-ui.netlify.app/components/dialogs/

Closes #19696
Solve #26386 (comment)

@eps1lon eps1lon added breaking change component: dialog This is the name of the generic UI component, not the React module! labels May 16, 2021
@mui-pr-bot
Copy link

mui-pr-bot commented May 16, 2021 •
edited
Loading

Details of bundle changes (experimental)

Generated by 🚫 dangerJS against 5ac46d0

@eps1lon eps1lon force-pushed the feat/DialogTitle/flatten branch 2 times, most recently from 511e0b7 to dcc15c5 Compare May 16, 2021 07:49
@eps1lon eps1lon changed the title [DialogTitle] Flatte DOM structure to remove disableTypography [DialogTitle] Flatten DOM structure to remove disableTypography May 17, 2021
@github-actions github-actions bot added the PR: out-of-date The pull request has merge conflicts and can't be merged label May 20, 2021
@oliviertassinari oliviertassinari changed the title [DialogTitle] Flatten DOM structure to remove disableTypography [Dialog] Flatten DialogTitle DOM structure to remove disableTypography May 22, 2021
@oliviertassinari oliviertassinari mentioned this pull request May 22, 2021
Closed
@github-actions github-actions bot removed the PR: out-of-date The pull request has merge conflicts and can't be merged label May 26, 2021
@github-actions github-actions bot mentioned this pull request May 26, 2021
Closed
@oliviertassinari
Copy link
Member

I have rebased on HEAD and push a new commit to fix the visual regression/match the updated spec.

@oliviertassinari oliviertassinari changed the title [Dialog] Flatten DialogTitle DOM structure to remove disableTypography [Dialog] Flatten DialogTitle DOM structure, remove disableTypography May 26, 2021
@oliviertassinari oliviertassinari marked this pull request as ready for review May 26, 2021 14:07
@oliviertassinari
Copy link
Member

cc @mui-org/core for review

siriwatknp
siriwatknp approved these changes May 31, 2021
View reviewed changes
Copy link
Member

@siriwatknp siriwatknp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me

@oliviertassinari oliviertassinari mentioned this pull request May 31, 2021
Closed
@oliviertassinari oliviertassinari merged commit 90153a0 into mui:next May 31, 2021
@github-actions github-actions bot mentioned this pull request May 31, 2021
Closed
@oliviertassinari oliviertassinari mentioned this pull request May 31, 2021
Closed
2 tasks
@mnajdova mnajdova mentioned this pull request Jun 17, 2021
Open
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@siriwatknp siriwatknp siriwatknp approved these changes

@mnajdova mnajdova Awaiting requested review from mnajdova

Assignees
No one assigned
Labels
breaking change component: dialog This is the name of the generic UI component, not the React module!
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Dialog] Flatten DialogTitle DOM structure
4 participants
@eps1lon @mui-pr-bot @oliviertassinari @siriwatknp