Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[TimePicker] Migrate ClockPicker to emotion #26389

Merged
merged 15 commits into from
May 21, 2021
Merged

[TimePicker] Migrate ClockPicker to emotion #26389

merged 15 commits into from
May 21, 2021

Conversation

siriwatknp
Copy link
Member

@siriwatknp siriwatknp commented May 20, 2021 •
edited by mnajdova
Loading

Closes #24405 🎉

@siriwatknp siriwatknp added the component: time picker This is the name of the generic UI component, not the React module! label May 20, 2021
@mui-pr-bot
Copy link

mui-pr-bot commented May 20, 2021 •
edited
Loading

Details of bundle changes (experimental)

@material-ui/lab: parsed: +0.08% , gzip: -0.10% 😍

Generated by 🚫 dangerJS against c5e5760

@siriwatknp siriwatknp mentioned this pull request May 20, 2021
Closed
@siriwatknp siriwatknp marked this pull request as ready for review May 20, 2021 10:48
@siriwatknp siriwatknp requested a review from mnajdova May 21, 2021 06:05
siriwatknp
siriwatknp commented May 21, 2021
View reviewed changes
packages/material-ui-lab/src/ClockPicker/ClockPicker.test.tsx Outdated
refInstanceof: window.HTMLDivElement,
muiName: 'MuiClockPicker',
// cannot test reactTestRenderer because of required context
testRootOverrides: null,
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This component does not have root slot.

siriwatknp
siriwatknp commented May 21, 2021
View reviewed changes
test/utils/describeConformanceV5.js Outdated
@@ -201,6 +205,38 @@ function testThemeStyleOverrides(element, getOptions) {
).to.toHaveComputedStyle(testStyle);
}
});

it("respect theme's styleOverrides specific slot", function test() {
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

add new test for specific slot. @mnajdova should it be another PR or this PR is fine?

Copy link
Member

@mnajdova mnajdova May 21, 2021 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's handle this in a separate PR. We can disable this test for the component with Todo and handle it in a follow up. I wouldn't add this logic in the describeConformance as it is not a conformant thing :)

@github-actions github-actions bot added the PR: out-of-date The pull request has merge conflicts and can't be merged label May 21, 2021
@github-actions github-actions bot added PR: out-of-date The pull request has merge conflicts and can't be merged and removed PR: out-of-date The pull request has merge conflicts and can't be merged labels May 21, 2021
@github-actions github-actions bot removed the PR: out-of-date The pull request has merge conflicts and can't be merged label May 21, 2021
@mnajdova
Copy link
Member

Not totally sure on these points

  • sx prop in not needed because there is no Root slot.
  • skip themeDefaultProps and themeVariants test because the implementation does not spread the props.

Testing
@mnajdova Because this component is public but no root slot, so need to update themeStyleOverrides test in describeConformanceV5 to be able to exclude testRootOverrides and test specific slot.

We should not make describeConformance friendly for testing things which are not conformant. I've skipped the themeStyleOverrides, we should fix this separately.

Now that this is the last component from the migration to @emotion (good job for taking this to the finish line @siriwatknp), we can revisit the code debt that we left, by resolving the Todos.

mnajdova
mnajdova approved these changes May 21, 2021
View reviewed changes
Copy link
Member

@mnajdova mnajdova left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Last one done 🎉 great work @siriwatknp

@mnajdova mnajdova merged commit 79f8dce into mui:next May 21, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mnajdova mnajdova mnajdova approved these changes

Assignees
No one assigned
Labels
component: time picker This is the name of the generic UI component, not the React module!
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Migrate all components to emotion
3 participants
@siriwatknp @mui-pr-bot @mnajdova