[Docs] Updated Docs for Grid List #2681
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Zadielerick
force-pushed
the
gridListDocsUpdate
branch
from
f9e3265 to
ff4ba9b
Compare
| import React from 'react'; | ||
| import GridList from 'material-ui/lib/grid-list/grid-list'; | ||
| import GridTile from 'material-ui/lib/grid-list/grid-tile'; | ||
| import StarBorder from 'material-ui/svg-icons/toggle/star-border'; |
oliviertassinari
added
docs
29 tasks
| style={{width: 500, height: 400, overflowY: 'auto', marginBottom: 24}} | ||
| > | ||
| { | ||
| tilesData.map(tile => <GridTile |
There was a problem hiding this comment.
Took me a while to get to bottom of this -_-
This little guy breaks code highlighting. Take it out into a variable and all works well:
const titleElements = tilesData.map(tile => <GridTile
key={tile.img}
title={tile.title}
actionIcon={<IconButton><StarBorder color="white"/></IconButton>}
actionPosition="left"
titlePosition="top"
titleBackground={gradientBg}
cols={tile.featured ? 2 : 1}
rows={tile.featured ? 2 : 1}
><img src={tile.img} /></GridTile>);
// ....
<GridList
cols={2}
cellHeight={200}
padding={1}
style={{width: 500, height: 400, overflowY: 'auto', marginBottom: 24}}
>
{titleElements}
</GridList>
// ....There was a problem hiding this comment.
@alitaheri Thank you! I couldn't figure out why it wasn't highlighting
Zadielerick
changed the title
| import GridList from 'material-ui/lib/grid-list/grid-list'; | ||
| import GridTile from 'material-ui/lib/grid-list/grid-tile'; | ||
| import StarBorder from 'material-ui/lib/svg-icons/toggle/star-border'; | ||
| import IconButton from 'icon-button'; |
There was a problem hiding this comment.
That won't work when people will copy past the example.
Use the material-ui/lib/...
|
@Zadielerick It looks good. |
Zadielerick
force-pushed
the
gridListDocsUpdate
branch
from
d98109c to
287659a
Compare
Zadielerick
force-pushed
the
gridListDocsUpdate
branch
from
287659a to
b280f5b
Compare
|
@Zadielerick Thanks a bunch 👍 👍 Awesome work 🎉 🎈 |
alitaheri
added a commit
that referenced
this pull request
Dec 29, 2015
[Docs] Updated Docs for Grid List
|
Thanks! |
|
@Zadielerick Yeah 🎉 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.