Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Webpack Example Babel 6 Upgrade #2709

Merged
merged 1 commit into from
Dec 29, 2015
Merged

Webpack Example Babel 6 Upgrade #2709

merged 1 commit into from
Dec 29, 2015

Conversation

bartekus
Copy link
Contributor

  • Babel 6 upgrade
  • Added es2015, react & stage-0 presets
  • Configured .babelrc to utilize es2015, react & stage-1
  • Adjusted webpack dev-server & production config to reflect babel upgrade changes
  • Upgraded all other modules to most recent version
  • Start & Build tested ok

…react & stage-0 presets - Configured .babelrc to utilize es2015, react & stage-1 - Adjusted webpack dev-server & production config to reflect babel upgrade changes - Upgraded all other modules to most recent version - Start & Build tested ok
@bartekus
Copy link
Contributor Author

I've taken the liberty of upgrading your example build and brought all the modules to their most current versions. Everything has been tested and works ok. Cheers!

@@ -1,4 +1,3 @@
{
"breakConfig": true,
"stage": 1,
"presets": ["es2015", "stage-1", "react"]
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we need stage 1?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That's what was used before so that's what I set it as however I've installed babel-preset-stage-0 which means all the stages are available, from 2 to 0 so feel free to modify this as necessary.

@oliviertassinari
Copy link
Member

@bartekus Yeah, thank for doing it, that was needed!

I see that you are in the webpack organisation, can we have your input on #2679 (tree-shaking)?

@bartekus
Copy link
Contributor Author

No problem, and of course, I'll have a look at #2679 and get back to you shortly with plan of action.

@bartekus
Copy link
Contributor Author

ok, #2679 is in my alley so I'm gonna take care of that along with upgrading react-hot-loader to react-transform-hmr so that you guys are as current as possible.

@alitaheri
Copy link
Member

@bartekus Thanks a bunch for doing this. 👍 👍

@newoga
Copy link
Contributor

newoga commented Dec 29, 2015

Sweet! 👍

@oliviertassinari
Copy link
Member

@bartekus I have just tested it. It's working fine. Thanks 👍.

upgrading react-hot-loader to react-transform-hmr so that you guys are as current as possible.

That sounds good 💃.

oliviertassinari added a commit that referenced this pull request Dec 29, 2015
@oliviertassinari oliviertassinari merged commit 9ec4dc2 into mui:master Dec 29, 2015
@zannager zannager added the package: system Specific to @mui/system label Mar 15, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
package: system Specific to @mui/system
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants