-
-
Notifications
You must be signed in to change notification settings - Fork 32.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Webpack Example Babel 6 Upgrade #2709
Webpack Example Babel 6 Upgrade #2709
Conversation
bartekus
commented
Dec 29, 2015
- Babel 6 upgrade
- Added es2015, react & stage-0 presets
- Configured .babelrc to utilize es2015, react & stage-1
- Adjusted webpack dev-server & production config to reflect babel upgrade changes
- Upgraded all other modules to most recent version
- Start & Build tested ok
…react & stage-0 presets - Configured .babelrc to utilize es2015, react & stage-1 - Adjusted webpack dev-server & production config to reflect babel upgrade changes - Upgraded all other modules to most recent version - Start & Build tested ok
I've taken the liberty of upgrading your example build and brought all the modules to their most current versions. Everything has been tested and works ok. Cheers! |
@@ -1,4 +1,3 @@ | |||
{ | |||
"breakConfig": true, | |||
"stage": 1, | |||
"presets": ["es2015", "stage-1", "react"] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do we need stage 1
?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
That's what was used before so that's what I set it as however I've installed babel-preset-stage-0 which means all the stages are available, from 2 to 0 so feel free to modify this as necessary.
No problem, and of course, I'll have a look at #2679 and get back to you shortly with plan of action. |
ok, #2679 is in my alley so I'm gonna take care of that along with upgrading react-hot-loader to react-transform-hmr so that you guys are as current as possible. |
@bartekus Thanks a bunch for doing this. 👍 👍 |
Sweet! 👍 |
@bartekus I have just tested it. It's working fine. Thanks 👍.
That sounds good 💃. |
[Example] Webpack Example Babel 6 Upgrade