Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[docs] Fix various layout issues with the v5 banner #27237

Merged
merged 6 commits into from
Jul 15, 2021
Merged

[docs] Fix various layout issues with the v5 banner #27237

merged 6 commits into from
Jul 15, 2021

Conversation

mnajdova
Copy link
Member

@mnajdova mnajdova commented Jul 12, 2021 •
edited by oliviertassinari
Loading

@mui-pr-bot
Copy link

mui-pr-bot commented Jul 12, 2021 •
edited
Loading

Details of bundle changes.

Comparing: 29e7f59...bac8fef

Details of page changes
bundle Size Change Size Gzip Change Gzip
/api-docs/outlined-input ▲ +10 B (+0.34% ) 2.99 kB -- -1 B
/api-docs/unstable-trap-focus ▼ -10 B (-0.68% ) 1.45 kB -- -1 B
/blog/2019-developer-survey-results ▲ +10 B (+0.13% ) 7.61 kB -- -1 B
/blog/2019 ▲ +10 B (+0.18% ) 5.47 kB -- -1 B
/blog/2020-q1-update ▲ +10 B (+0.18% ) 5.56 kB -- -1 B
/blog/2020-q3-update ▲ +10 B (+0.14% ) 7.36 kB -- -1 B
/blog/2021-q2-update ▲ +10 B (+0.13% ) 7.86 kB -- -1 B
/blog/april-2019-update ▲ +10 B (+0.23% ) 4.35 kB -- -1 B
/blog/august-2019-update ▲ +10 B (+0.29% ) 3.47 kB -- -1 B
/blog/danail-hadjiatanasov-joining ▲ +10 B (+0.29% ) 3.42 kB -- -1 B
/blog/july-2019-update ▲ +10 B (+0.30% ) 3.37 kB -- -1 B
/blog/june-2019-update ▲ +10 B (+0.31% ) 3.25 kB -- -1 B
/blog/marija-najdova-joining ▲ +10 B (+0.30% ) 3.33 kB -- -1 B
/blog/matheus-wichman-joining ▲ +10 B (+0.29% ) 3.46 kB -- -1 B
/blog/may-2019-update ▲ +10 B (+0.28% ) 3.59 kB -- -1 B
/blog/november-2019-update ▲ +10 B (+0.25% ) 3.99 kB -- -1 B
/blog/september-2019-update ▲ +10 B (+0.26% ) 3.92 kB -- -1 B
/company/about ▲ +10 B (+0.57% ) 1.76 kB -- -1 B
/company/contact ▲ +10 B (+0.75% ) 1.35 kB -- -1 B
/company/developer-advocate ▲ +10 B (+0.40% ) 2.5 kB -- -1 B
/performance/table-emotion ▼ -10 B (-0.12% ) 8.49 kB -- -1 B
/_app -- 37.1 kB -- -1 B
/api-docs/accordion-actions -- 1.48 kB -- -1 B
/api-docs/accordion-details -- 1.4 kB -- -1 B
/api-docs/accordion-summary -- 1.97 kB -- -1 B
/api-docs/accordion -- 1.97 kB -- -1 B
/api-docs/alert-title -- 1.4 kB -- -1 B
/api-docs/alert -- 2.4 kB -- -1 B
/api-docs/app-bar -- 1.94 kB -- -1 B
/api-docs/autocomplete -- 4.62 kB -- -1 B
/api-docs/avatar-group -- 1.51 kB -- -1 B
/api-docs/avatar -- 1.88 kB -- -1 B
/api-docs/backdrop -- 1.73 kB -- -1 B
/api-docs/badge -- 2.25 kB -- -1 B
/api-docs/bottom-navigation-action -- 1.81 kB -- -1 B
/api-docs/bottom-navigation -- 1.7 kB -- -1 B
/api-docs/breadcrumbs -- 1.79 kB -- -1 B
/api-docs/button-base -- 2.22 kB -- -1 B
/api-docs/button-group -- 2.22 kB -- -1 B
/api-docs/button -- 2.53 kB -- -1 B
/api-docs/card-action-area -- 1.58 kB -- -1 B
/api-docs/card-actions -- 1.47 kB -- -1 B
/api-docs/card-content -- 1.45 kB -- -1 B
/api-docs/card-header -- 1.78 kB -- -1 B
/api-docs/card-media -- 1.69 kB -- -1 B
/api-docs/card -- 1.5 kB -- -1 B
/api-docs/checkbox -- 2.3 kB -- -1 B
/api-docs/chip -- 2.46 kB -- -1 B
/api-docs/circular-progress -- 2.09 kB -- -1 B
/api-docs/click-away-listener -- 1.45 kB -- -1 B
/api-docs/collapse -- 2.22 kB -- -1 B
/api-docs/container -- 1.83 kB -- -1 B
/api-docs/css-baseline -- 1.4 kB -- -1 B
/api-docs/dialog-actions -- 1.47 kB -- -1 B
/api-docs/dialog-content-text -- 1.48 kB -- -1 B
/api-docs/dialog-content -- 1.45 kB -- -1 B
/api-docs/dialog-title -- 1.49 kB -- -1 B
/api-docs/dialog -- 2.85 kB -- -1 B
/api-docs/divider -- 1.81 kB -- -1 B
/api-docs/drawer -- 2.13 kB -- -1 B
/api-docs/expansion-panel-actions -- 1.55 kB -- -1 B
/api-docs/expansion-panel-details -- 1.47 kB -- -1 B
/api-docs/expansion-panel-summary -- 1.84 kB -- -1 B
/api-docs/expansion-panel -- 2.04 kB -- -1 B
/api-docs/fab -- 2.14 kB -- -1 B
/api-docs/fade -- 1.5 kB -- -1 B
/api-docs/filled-input -- 2.87 kB -- -1 B
/api-docs/form-control-label -- 1.99 kB -- -1 B
/api-docs/form-control -- 2.36 kB -- -1 B
/api-docs/form-group -- 1.55 kB -- -1 B
/api-docs/form-helper-text -- 1.91 kB -- -1 B
/api-docs/form-label -- 1.84 kB -- -1 B
/api-docs/grid-list-tile-bar -- 1.87 kB -- -1 B
/api-docs/grid-list-tile -- 1.79 kB -- -1 B
/api-docs/grid-list -- 1.7 kB -- -1 B
/api-docs/grid -- 2.63 kB -- -1 B
/api-docs/grow -- 1.55 kB -- -1 B
/api-docs/hidden -- 1.53 kB -- -1 B
/api-docs/icon-button -- 2.07 kB -- -1 B
/api-docs/icon -- 1.79 kB -- -1 B
/api-docs/image-list-item-bar -- 1.85 kB -- -1 B
/api-docs/image-list-item -- 1.65 kB -- -1 B
/api-docs/image-list -- 1.7 kB -- -1 B
/api-docs/input-adornment -- 1.95 kB -- -1 B
/api-docs/input-base -- 2.98 kB -- -1 B
/api-docs/input-label -- 2.07 kB -- -1 B
/api-docs/input -- 2.83 kB -- -1 B
/api-docs/linear-progress -- 2.03 kB -- -1 B
/api-docs/link -- 1.94 kB -- -1 B
/api-docs/list-item-avatar -- 1.51 kB -- -1 B
/api-docs/list-item-icon -- 1.51 kB -- -1 B
/api-docs/list-item-secondary-action -- 1.47 kB -- -1 B
/api-docs/list-item-text -- 1.79 kB -- -1 B
/api-docs/list-item -- 2.25 kB -- -1 B
/api-docs/list-subheader -- 1.75 kB -- -1 B
/api-docs/list -- 1.68 kB -- -1 B
/api-docs/menu-item -- 1.74 kB -- -1 B
/api-docs/menu-list -- 1.57 kB -- -1 B
/api-docs/menu -- 2.54 kB -- -1 B
/api-docs/mobile-stepper -- 1.94 kB -- -1 B
/api-docs/modal -- 2.51 kB -- -1 B
/api-docs/native-select -- 2.11 kB -- -1 B
/api-docs/no-ssr -- 1.3 kB -- -1 B
/api-docs/pagination-item -- 1.97 kB -- -1 B
/api-docs/pagination -- 2.24 kB -- -1 B
/api-docs/paper -- 1.87 kB -- -1 B
/api-docs/popover -- 2.75 kB -- -1 B
/api-docs/popper -- 1.92 kB -- -1 B
/api-docs/portal -- 1.36 kB -- -1 B
/api-docs/radio-group -- 1.45 kB -- -1 B
/api-docs/radio -- 2.12 kB -- -1 B
/api-docs/rating -- 2.49 kB -- -1 B
/api-docs/root-ref -- 1.43 kB -- -1 B
/api-docs/scoped-css-baseline -- 1.4 kB -- -1 B
/api-docs/select -- 2.96 kB -- -1 B
/api-docs/skeleton -- 1.87 kB -- -1 B
/api-docs/slide -- 1.54 kB -- -1 B
/api-docs/slider -- 3.11 kB -- -1 B
/api-docs/snackbar-content -- 1.61 kB -- -1 B
/api-docs/snackbar -- 2.77 kB -- -1 B
/api-docs/speed-dial-action -- 2.04 kB -- -1 B
/api-docs/speed-dial-icon -- 1.55 kB -- -1 B
/api-docs/speed-dial -- 2.32 kB -- -1 B
/api-docs/step-button -- 1.63 kB -- -1 B
/api-docs/step-connector -- 1.54 kB -- -1 B
/api-docs/step-content -- 1.72 kB -- -1 B
/api-docs/step-icon -- 1.57 kB -- -1 B
/api-docs/step-label -- 1.9 kB -- -1 B
/api-docs/step -- 1.64 kB -- -1 B
/api-docs/stepper -- 1.84 kB -- -1 B
/api-docs/svg-icon -- 2.27 kB -- -1 B
/api-docs/swipeable-drawer -- 2.01 kB -- -1 B
/api-docs/switch -- 2.46 kB -- -1 B
/api-docs/tab-context -- 1.08 kB -- -1 B
/api-docs/tab-list -- 1.09 kB -- -1 B
/api-docs/tab-panel -- 1.48 kB -- -1 B
/api-docs/tab-scroll-button -- 1.62 kB -- -1 B
/api-docs/tab -- 1.97 kB -- -1 B
/api-docs/table-body -- 1.47 kB -- -1 B
/api-docs/table-cell -- 2.16 kB -- -1 B
/api-docs/table-container -- 1.48 kB -- -1 B
/api-docs/table-footer -- 1.47 kB -- -1 B
/api-docs/table-head -- 1.46 kB -- -1 B
/api-docs/table-pagination -- 2.54 kB -- -1 B
/api-docs/table-row -- 1.69 kB -- -1 B
/api-docs/table-sort-label -- 1.83 kB -- -1 B
/api-docs/table -- 1.73 kB -- -1 B
/api-docs/tabs -- 2.68 kB -- -1 B
/api-docs/text-field -- 3.19 kB -- -1 B
/api-docs/textarea-autosize -- 1.18 kB -- -1 B
/api-docs/timeline-connector -- 1.4 kB -- -1 B
/api-docs/timeline-content -- 1.43 kB -- -1 B
/api-docs/timeline-dot -- 1.63 kB -- -1 B
/api-docs/timeline-item -- 1.54 kB -- -1 B
/api-docs/timeline-opposite-content -- 1.44 kB -- -1 B
/api-docs/timeline-separator -- 1.4 kB -- -1 B
/api-docs/timeline -- 1.52 kB -- -1 B
/api-docs/toggle-button-group -- 1.92 kB -- -1 B
/api-docs/toggle-button -- 1.79 kB -- -1 B
/api-docs/toolbar -- 1.65 kB -- -1 B
/api-docs/tooltip -- 2.57 kB -- -1 B
/api-docs/tree-item -- 1.89 kB -- -1 B
/api-docs/tree-view -- 1.92 kB -- -1 B
/api-docs/typography -- 2.59 kB -- -1 B
/api-docs/zoom -- 1.52 kB -- -1 B
/blog/2020-developer-survey-results -- 9.51 kB -- -1 B
/blog/2020-introducing-sketch -- 4.73 kB -- -1 B
/blog/2020-q2-update -- 5.61 kB -- -1 B
/blog/2020 -- 6.49 kB -- -1 B
/blog/2021-q1-update -- 7.07 kB -- -1 B
/blog/danilo-leal-joining -- 3.47 kB -- -1 B
/blog/december-2019-update -- 3.6 kB -- -1 B
/blog/march-2019-update -- 3.77 kB -- -1 B
/blog/material-ui-v1-is-out -- 7.93 kB -- -1 B
/blog/material-ui-v4-is-out -- 10.9 kB -- -1 B
/blog/michal-dudak-joining -- 3.79 kB -- -1 B
/blog/october-2019-update -- 3.73 kB -- -1 B
/blog/siriwat-kunaporn-joining -- 3.36 kB -- -1 B
/blog/spotlight-damien-tassone -- 3.3 kB -- -1 B
/company/careers -- 9.27 kB -- -1 B
/company/full-stack-engineer -- 3.25 kB -- -1 B
/company/product-manager -- 2.94 kB -- -1 B
/company/react-engineer -- 5.04 kB -- -1 B
/company/software-engineer-intern -- 4.12 kB -- -1 B
/components/about-the-lab -- 11.7 kB -- -1 B
/components/accordion -- 22.7 kB -- -1 B
/components/alert -- 14 kB -- -1 B
/components/app-bar -- 30.2 kB -- -1 B
/components/autocomplete -- 103 kB -- -1 B
/components/avatars -- 10.1 kB -- -1 B
/components/backdrop -- 3.35 kB -- -1 B
/components/badges -- 15.4 kB -- -1 B
/components/bottom-navigation -- 6.16 kB -- -1 B
/components/box -- 8.36 kB -- -1 B
/components/breadcrumbs -- 14.7 kB -- -1 B
/components/button-group -- 8.04 kB -- -1 B
/components/buttons -- 27.3 kB -- -1 B
/components/cards -- 17.4 kB -- -1 B
/components/checkboxes -- 16.5 kB -- -1 B
/components/chips -- 21.8 kB -- -1 B
/components/click-away-listener -- 6.07 kB -- -1 B
/components/container -- 3.95 kB -- -1 B
/components/css-baseline -- 7.37 kB -- -1 B
/components/dialogs -- 42.9 kB -- -1 B
/components/dividers -- 13.1 kB -- -1 B
/components/drawers -- 31.4 kB -- -1 B
/components/floating-action-button -- 11 kB -- -1 B
/components/grid -- 32.8 kB -- -1 B
/components/hidden -- 10.5 kB -- -1 B
/components/icons -- 28.3 kB -- -1 B
/components/image-list -- 12.3 kB -- -1 B
/components/links -- 7.33 kB -- -1 B
/components/lists -- 26.2 kB -- -1 B
/components/material-icons -- 729 kB -- -1 B
/components/menus -- 24.5 kB -- -1 B
/components/modal -- 12.6 kB -- -1 B
/components/no-ssr -- 5.5 kB -- -1 B
/components/pagination -- 8.83 kB -- -1 B
/components/paper -- 3.41 kB -- -1 B
/components/pickers -- 37.7 kB -- -1 B
/components/popover -- 17.5 kB -- -1 B
/components/popper -- 22.9 kB -- -1 B
/components/portal -- 3.32 kB -- -1 B
/components/progress -- 19.5 kB -- -1 B
/components/radio-buttons -- 14.9 kB -- -1 B
/components/rating -- 10.7 kB -- -1 B
/components/selects -- 32.8 kB -- -1 B
/components/skeleton -- 14.1 kB -- -1 B
/components/slider -- 16.3 kB -- -1 B
/components/snackbars -- 23.2 kB -- -1 B
/components/speed-dial -- 15.3 kB -- -1 B
/components/steppers -- 36.5 kB -- -1 B
/components/switches -- 17 kB -- -1 B
/components/tables -- 108 kB -- -1 B
/components/tabs -- 24.9 kB -- -1 B
/components/text-fields -- 56.1 kB -- -1 B
/components/textarea-autosize -- 3.05 kB -- -1 B
/components/timeline -- 7.49 kB -- -1 B
/components/toggle-button -- 11.9 kB -- -1 B
/components/tooltips -- 18.1 kB -- -1 B
/components/transfer-list -- 9.79 kB -- -1 B
/components/transitions -- 12.1 kB -- -1 B
/components/tree-view -- 11.5 kB -- -1 B
/components/typography -- 12.6 kB -- -1 B
/components/use-media-query -- 13.6 kB -- -1 B
/customization/breakpoints -- 17.1 kB -- -1 B
/customization/color -- 19.1 kB -- -1 B
/customization/components -- 37.3 kB -- -1 B
/customization/default-theme -- 8.8 kB -- -1 B
/customization/density -- 10.2 kB -- -1 B
/customization/globals -- 5.12 kB -- -1 B
/customization/palette -- 17.1 kB -- -1 B
/customization/spacing -- 2.98 kB -- -1 B
/customization/theming -- 19.6 kB -- -1 B
/customization/typography -- 14.2 kB -- -1 B
/customization/z-index -- 3.52 kB -- -1 B
/discover-more/backers -- 3.31 kB -- -1 B
/discover-more/changelog -- 1.39 kB -- -1 B
/discover-more/languages -- 3.4 kB -- -1 B
/discover-more/related-projects -- 9.25 kB -- -1 B
/discover-more/roadmap -- 2.9 kB -- -1 B
/discover-more/showcase -- 15.4 kB -- -1 B
/discover-more/team -- 7.26 kB -- -1 B
/discover-more/vision -- 6.83 kB -- -1 B
/getting-started/example-projects -- 7.4 kB -- -1 B
/getting-started/faq -- 40.4 kB -- -1 B
/getting-started/installation -- 9.06 kB -- -1 B
/getting-started/learn -- 8.6 kB -- -1 B
/getting-started/support -- 12.4 kB -- -1 B
/getting-started/supported-components -- 8.06 kB -- -1 B
/getting-started/supported-platforms -- 6.23 kB -- -1 B
/getting-started/templates -- 8.89 kB -- -1 B
/getting-started/templates/album -- 5.57 kB -- -1 B
/getting-started/templates/blog -- 7.45 kB -- -1 B
/getting-started/templates/checkout -- 10.2 kB -- -1 B
/getting-started/templates/dashboard -- 8.87 kB -- -1 B
/getting-started/templates/pricing -- 7.81 kB -- -1 B
/getting-started/templates/sign-in-side -- 8.23 kB -- -1 B
/getting-started/templates/sign-in -- 8.47 kB -- -1 B
/getting-started/templates/sign-up -- 8.58 kB -- -1 B
/getting-started/templates/sticky-footer -- 1.54 kB -- -1 B
/getting-started/usage -- 9.46 kB -- -1 B
/guides/api -- 15 kB -- -1 B
/guides/composition -- 17.2 kB -- -1 B
/guides/flow -- 2.36 kB -- -1 B
/guides/interoperability -- 16.1 kB -- -1 B
/guides/localization -- 10.1 kB -- -1 B
/guides/migration-v0x -- 7.78 kB -- -1 B
/guides/migration-v3 -- 18.7 kB -- -1 B
/guides/minimizing-bundle-size -- 14.9 kB -- -1 B
/guides/responsive-ui -- 4.64 kB -- -1 B
/guides/right-to-left -- 5.37 kB -- -1 B
/guides/server-rendering -- 9.88 kB -- -1 B
/guides/testing -- 8.18 kB -- -1 B
/guides/typescript -- 15.6 kB -- -1 B
/performance/table-component -- 1.44 kB -- -1 B
/performance/table-hook -- 2.24 kB -- -1 B
/performance/table-mui -- 4.49 kB -- -1 B
/performance/table-raw -- 613 B -- -1 B
/performance/table-styled-components -- 2.61 kB -- -1 B
/premium-themes/onepirate -- 7.33 kB -- -1 B
/premium-themes/onepirate/forgot-password -- 1.01 kB -- -1 B
/premium-themes/onepirate/privacy -- 4.44 kB -- -1 B
/premium-themes/onepirate/sign-in -- 1.07 kB -- -1 B
/premium-themes/onepirate/sign-up -- 1.12 kB -- -1 B
/premium-themes/onepirate/terms -- 11.8 kB -- -1 B
/premium-themes/paperbase -- 7.71 kB -- -1 B
/production-error -- 3.96 kB -- -1 B
/styles/advanced -- 33.4 kB -- -1 B
/styles/api -- 16.4 kB -- -1 B
/styles/basics -- 15.9 kB -- -1 B
/system/api -- 3.6 kB -- -1 B
/system/basics -- 27.4 kB -- -1 B
/system/borders -- 3.72 kB -- -1 B
/system/display -- 6.2 kB -- -1 B
/system/flexbox -- 5.4 kB -- -1 B
/system/palette -- 4.17 kB -- -1 B
/system/positions -- 2.32 kB -- -1 B
/system/shadows -- 3.93 kB -- -1 B
/system/sizing -- 3.35 kB -- -1 B
/system/spacing -- 6.81 kB -- -1 B
/system/typography -- 4.03 kB -- -1 B
/versions -- 23.2 kB -- -1 B
docs:chunk:shared -- 64.6 kB -- -1 B
docs:shared:chunk/commons -- 5.99 kB -- -1 B
docs:shared:chunk/framework -- 42.3 kB -- -1 B
docs:shared:runtime/main -- 6.78 kB -- -1 B
docs:shared:runtime/webpack -- 1.24 kB -- -1 B
bundle Size Change Size Gzip Change Gzip
@material-ui/core -- 383 kB -- 104 kB
@material-ui/lab -- 225 kB -- 66.1 kB
@material-ui/styles -- 53.2 kB -- 15.9 kB
@material-ui/system -- 17.5 kB -- 4.56 kB
@material-ui/utils -- 7.19 kB -- 2.61 kB
Accordion -- 78.9 kB -- 24.7 kB
AccordionActions -- 68.2 kB -- 21.3 kB
AccordionDetails -- 68.1 kB -- 21.2 kB
AccordionSummary -- 83.9 kB -- 26.4 kB
Alert -- 89.1 kB -- 28 kB
AlertTitle -- 70.4 kB -- 22 kB
AppBar -- 70.2 kB -- 21.9 kB
Autocomplete -- 138 kB -- 43.2 kB
Avatar -- 71.4 kB -- 22.2 kB
AvatarGroup -- 72.5 kB -- 22.8 kB
Backdrop -- 74.8 kB -- 23.1 kB
Badge -- 73 kB -- 22.3 kB
BottomNavigation -- 68.5 kB -- 21.4 kB
BottomNavigationAction -- 81.3 kB -- 25.7 kB
Box -- 75.2 kB -- 22.7 kB
Breadcrumbs -- 86.3 kB -- 27.2 kB
Button -- 85.5 kB -- 26.2 kB
ButtonBase -- 79.7 kB -- 25 kB
ButtonGroup -- 89.2 kB -- 27.4 kB
Card -- 69 kB -- 21.5 kB
CardActionArea -- 80.8 kB -- 25.5 kB
CardActions -- 68.2 kB -- 21.2 kB
CardContent -- 68.1 kB -- 21.2 kB
CardHeader -- 71.3 kB -- 22.3 kB
CardMedia -- 68.5 kB -- 21.4 kB
Checkbox -- 88 kB -- 27.8 kB
Chip -- 88.5 kB -- 27.1 kB
CircularProgress -- 70.3 kB -- 22 kB
ClickAwayListener -- 4.16 kB -- 1.67 kB
Collapse -- 75.3 kB -- 23.2 kB
colorManipulator -- 4.21 kB -- 1.65 kB
Container -- 69.4 kB -- 21.6 kB
CssBaseline -- 68.1 kB -- 21.3 kB
Dialog -- 90.1 kB -- 28.1 kB
DialogActions -- 68.2 kB -- 21.3 kB
DialogContent -- 68.4 kB -- 21.3 kB
DialogContentText -- 70.2 kB -- 21.9 kB
DialogTitle -- 70.5 kB -- 22 kB
Divider -- 68.8 kB -- 21.5 kB
docs:/ -- 13.3 kB -- -1 B
docs:/_app -- 37.1 kB -- -1 B
Drawer -- 92.1 kB -- 28 kB
ExpansionPanel -- 78.9 kB -- 24.7 kB
ExpansionPanelActions -- 68.2 kB -- 21.3 kB
ExpansionPanelDetails -- 68.1 kB -- 21.2 kB
ExpansionPanelSummary -- 83.9 kB -- 26.5 kB
Fab -- 82.6 kB -- 25.7 kB
Fade -- 29.5 kB -- 9.85 kB
FilledInput -- 79.9 kB -- 24.7 kB
FormControl -- 70.6 kB -- 21.9 kB
FormControlLabel -- 71.7 kB -- 22.4 kB
FormGroup -- 68.1 kB -- 21.2 kB
FormHelperText -- 69.5 kB -- 21.5 kB
FormLabel -- 69.7 kB -- 21.5 kB
Grid -- 71.3 kB -- 22.2 kB
GridList -- 68.6 kB -- 21.4 kB
GridListTile -- 69.9 kB -- 21.8 kB
GridListTileBar -- 69.3 kB -- 21.6 kB
Grow -- 30.1 kB -- 10.1 kB
Hidden -- 72.2 kB -- 22.5 kB
Icon -- 69 kB -- 21.5 kB
IconButton -- 81.9 kB -- 25.6 kB
ImageList -- 68.7 kB -- 21.4 kB
ImageListItem -- 69.9 kB -- 21.8 kB
ImageListItemBar -- 69.4 kB -- 21.6 kB
Input -- 78.8 kB -- 24.5 kB
InputAdornment -- 71.3 kB -- 22.3 kB
InputBase -- 76.9 kB -- 24 kB
InputLabel -- 71.5 kB -- 22 kB
LinearProgress -- 71.6 kB -- 22.2 kB
Link -- 72.8 kB -- 22.9 kB
List -- 68.5 kB -- 21.2 kB
ListItem -- 82.8 kB -- 25.9 kB
ListItemAvatar -- 68.2 kB -- 21.2 kB
ListItemIcon -- 68.3 kB -- 21.3 kB
ListItemSecondaryAction -- 68.1 kB -- 21.2 kB
ListItemText -- 71.2 kB -- 22.3 kB
ListSubheader -- 69 kB -- 21.5 kB
Menu -- 95.8 kB -- 29.4 kB
MenuItem -- 83.9 kB -- 26.2 kB
MenuList -- 72.2 kB -- 22.5 kB
MobileStepper -- 74.1 kB -- 23.1 kB
Modal -- 15.1 kB -- 5.28 kB
NativeSelect -- 83.2 kB -- 26.2 kB
NoSsr -- 2.18 kB -- 1.03 kB
OutlinedInput -- 80.9 kB -- 25.1 kB
packages/material-ui/material-ui.production.min.js -- 337 kB -- 96.5 kB
Pagination -- 90.3 kB -- 27.8 kB
PaginationItem -- 86.7 kB -- 26.7 kB
Paper -- 68.5 kB -- 21.2 kB
Popover -- 90 kB -- 27.8 kB
Popper -- 28.7 kB -- 10.3 kB
Portal -- 2.87 kB -- 1.29 kB
Radio -- 89 kB -- 28.1 kB
RadioGroup -- 70.1 kB -- 21.6 kB
Rating -- 77.1 kB -- 24.7 kB
RootRef -- 4.64 kB -- 1.76 kB
ScopedCssBaseline -- 69 kB -- 21.6 kB
Select -- 123 kB -- 36.7 kB
Skeleton -- 69.4 kB -- 21.8 kB
Slide -- 31.2 kB -- 10.4 kB
Slider -- 82.1 kB -- 26 kB
Snackbar -- 82.6 kB -- 25.8 kB
SnackbarContent -- 69.7 kB -- 21.8 kB
SpeedDial -- 92.8 kB -- 29.4 kB
SpeedDialAction -- 124 kB -- 39.5 kB
SpeedDialIcon -- 70.8 kB -- 22.1 kB
Step -- 68.9 kB -- 21.5 kB
StepButton -- 88.1 kB -- 27.7 kB
StepConnector -- 68.9 kB -- 21.5 kB
StepContent -- 76.4 kB -- 23.8 kB
StepIcon -- 70.8 kB -- 21.9 kB
StepLabel -- 74.8 kB -- 23 kB
Stepper -- 70.9 kB -- 22.2 kB
styles/createTheme -- 22.5 kB -- 7.75 kB
SvgIcon -- 69.2 kB -- 21.5 kB
SwipeableDrawer -- 99.5 kB -- 31.2 kB
Switch -- 87.2 kB -- 27.5 kB
Tab -- 82.3 kB -- 26.1 kB
TabContext -- 2.65 kB -- 1.15 kB
Table -- 68.7 kB -- 21.5 kB
TableBody -- 68.3 kB -- 21.3 kB
TableCell -- 70.3 kB -- 22 kB
TableContainer -- 68.1 kB -- 21.2 kB
TableFooter -- 68.3 kB -- 21.3 kB
TableHead -- 68.3 kB -- 21.3 kB
TablePagination -- 150 kB -- 44.2 kB
TableRow -- 68.7 kB -- 21.4 kB
TableSortLabel -- 83.2 kB -- 26.2 kB
TabList -- 93.2 kB -- 29.7 kB
TabPanel -- 69 kB -- 21.5 kB
Tabs -- 92 kB -- 28.7 kB
TabScrollButton -- 82.8 kB -- 25.9 kB
TextareaAutosize -- 5.28 kB -- 2.22 kB
TextField -- 132 kB -- 38.9 kB
Timeline -- 68.6 kB -- 21.4 kB
TimelineConnector -- 68.1 kB -- 21.2 kB
TimelineContent -- 68.6 kB -- 21.3 kB
TimelineDot -- 69.2 kB -- 21.5 kB
TimelineItem -- 69.3 kB -- 21.6 kB
TimelineOppositeContent -- 68.7 kB -- 21.4 kB
TimelineSeparator -- 68.1 kB -- 21.2 kB
ToggleButton -- 81.9 kB -- 25.9 kB
ToggleButtonGroup -- 69.5 kB -- 21.7 kB
Toolbar -- 68.5 kB -- 21.4 kB
Tooltip -- 109 kB -- 34.3 kB
TreeItem -- 82.3 kB -- 26.1 kB
TreeView -- 74.5 kB -- 23.3 kB
Typography -- 69.8 kB -- 21.7 kB
Unstable_TrapFocus -- 3.87 kB -- 1.59 kB
useAutocomplete -- 14.7 kB -- 5.27 kB
useMediaQuery -- 2.56 kB -- 1.06 kB
useScrollTrigger -- 2.66 kB -- 1.08 kB
Zoom -- 29.6 kB -- 9.98 kB

Generated by 🚫 dangerJS against bac8fef

oliviertassinari
oliviertassinari reviewed Jul 12, 2021
View reviewed changes
Copy link
Member

@oliviertassinari oliviertassinari left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What's the height of the banner, 36px?

@mnajdova
Copy link
Member Author

What's the height of the banner, 36px?

Yes, but it felt better with 30px margin. I could update.

@oliviertassinari
Copy link
Member

oliviertassinari commented Jul 13, 2021 •
edited
Loading

Yes, but it felt better with 30px margin. I could update.

Ok, I didn't realize we were polishing the value too, makes sense. I asked because I have made a change in an opposite direction in 125f3db#diff-77f04bc58bbbb50bc7d3dea9ec533b08d76f110c581114cda8105da367d236a5R12 to fix an issue with the link anchor origin. I don't have a real preference on the approach as long as it's consistent. I'm unsubscribing to PR. Maybe in v5 we should use more constants, to make the math visible. It's never obvious if the value is purely from a design one or if it satisfies a layout constraint.

@oliviertassinari oliviertassinari added the priority: important This change can make a difference label Jul 14, 2021
@mnajdova
Copy link
Member Author

Ok, I didn't realize we were polishing the value too, makes sense. I asked because I have made a change in an opposite direction in 125f3db#diff-77f04bc58bbbb50bc7d3dea9ec533b08d76f110c581114cda8105da367d236a5R12 to fix an issue with the link anchor origin. I don't have a real preference on the approach as long as it's consistent. I'm unsubscribing to PR. Maybe in v5 we should use more constants, to make the math visible. It's never obvious if the value is purely from a design one or if it satisfies a layout constraint.

Agree, let me in that case update to 36 so that we are going to be consistent.

@mnajdova mnajdova requested review from eps1lon and removed request for eps1lon July 14, 2021 15:54
@oliviertassinari oliviertassinari added the docs Improvements or additions to the documentation label Jul 15, 2021
siriwatknp
siriwatknp approved these changes Jul 15, 2021
View reviewed changes
Copy link
Member

@siriwatknp siriwatknp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 I don't spot any issue.

@mnajdova mnajdova merged commit f3d2d7a into mui:master Jul 15, 2021
@oliviertassinari
Copy link
Member

I have pushed the changes to the docs repo so they can go live within the next few minutes.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@siriwatknp siriwatknp siriwatknp approved these changes

@oliviertassinari oliviertassinari Awaiting requested review from oliviertassinari

@eps1lon eps1lon Awaiting requested review from eps1lon

Assignees
No one assigned
Labels
docs Improvements or additions to the documentation priority: important This change can make a difference
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@mnajdova @mui-pr-bot @oliviertassinari @eps1lon @siriwatknp