[Pickers] Don't pass down unnecessary props

[michal-perlakowski]

Fixes mui/mui-x#6487.

Demo with the issue: https://codesandbox.io/s/custominput-material-demo-forked-r3064
Demo with the fix: https://codesandbox.io/s/custominput-material-demo-forked-kw722

• I have followed (at least) the PR section of the contributing guide.

[mui-pr-bot]

Details of bundle changes (experimental)

@material-ui/lab: parsed: +1.62% , gzip: +0.80%

Generated by 🚫 dangerJS against ffffb42

[michal-perlakowski]

I just noticed this comment in CalendarPicker.test.tsx:

// TODO: Fix CalendarPicker is not spreading props on root

So it seems the props should be spread after all. I'll change this PR to spread props on both MonthPicker and YearPicker, but without props that are irrelevant here, like renderInput and inputFormat. @oliviertassinari What about PickersCalendar? It currently returns a Fragment - should we change it to a div?

[eps1lon]

TODO: Fix CalendarPicker is not spreading props on root

Could you check when this was added?

I think I planned to explicitly pick which prop goes where and nost just spread everything down. This may add to the bundle size but makes it easier to track which prop goes where.

[michal-perlakowski]

@eps1lon It was added during migration to emotion in #26390.

[oliviertassinari]

Won't these changes break the conformance tests of this public component?

[michal-perlakowski]

@oliviertassinari Yes, the current changes broke the conformance test, but we could just disable that check, like in the YearPicker. The question is if we want to:

1. Pass props to the root component by spreading other props.
2. Pass props to the root component (and maybe other components) through ComponentsProps.
3. Not pass custom props to the root component.

I think this should be unified across different picker views.

[eps1lon]

I think the problem is rather the components that use MonthPicker and just pass unsupported props. That's where we want to filter the props.

Removing conformance is a non-starter.

[mnajdova]

Seems like there is not much activity on the pull request, and considering that we are moving the pickers to https://github.com/mui-org/material-ui-x I am closing the pull request. cc @flaviendelangle