Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[docs] Bring back Select#onChange signature API #27443

Merged
merged 1 commit into from
Aug 5, 2021

Conversation

eps1lon
Copy link
Member

@eps1lon eps1lon commented Jul 26, 2021

Follow-up to #27370. The documented signature wasn't ideal anyway. doctrine can't parse more complex types as well. We may want to switch to TSDoc parsers to support more complex types. For example, here I would've wanted to type event as import('@material-ui/core/Select').SelectChangeEvent so that people know where the type comes from.

Noticed when reviewing snapshot changes: https://github.com/eps1lon/mui-scripts-incubator/pull/2795/files

@eps1lon eps1lon added docs Improvements or additions to the documentation component: select This is the name of the generic UI component, not the React module! labels Jul 26, 2021
@mui-pr-bot
Copy link

mui-pr-bot commented Jul 26, 2021

No bundle size changes (experimental)

Generated by 🚫 dangerJS against 8f9bca0

@eps1lon eps1lon marked this pull request as ready for review July 26, 2021 07:24
@eps1lon eps1lon merged commit f4c0163 into mui:next Aug 5, 2021
@eps1lon eps1lon deleted the docs/onchange-malformed branch August 5, 2021 08:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component: select This is the name of the generic UI component, not the React module! docs Improvements or additions to the documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants