Update Documentation for Buttons #2745
Conversation
Zadielerick
force-pushed
the
buttonsDocsUpdate
branch
from
979240d
to
69d5736
Compare
| exampleImageInput: { | ||
| cursor: 'pointer', | ||
| position: 'absolute', | ||
| top: '0', |
There was a problem hiding this comment.
the quotes are not needed, what about 0?
oliviertassinari
added
docs
Zadielerick
force-pushed
the
buttonsDocsUpdate
branch
from
69d5736
to
b4880a8
Compare
| @@ -222,9 +283,9 @@ const FlatButton = React.createClass({ | |||
| this.props.onMouseLeave(e); | |||
| }, | |||
|
|
|||
| _handleTouchStart(e) { | |||
| _handleTouchTap(e) { | |||
| this.setState({touch: true}); | |||
There was a problem hiding this comment.
Regarding this line. It's working like this but it would be better to have the touch variable as an instance property rather than in the state.
By the way, in the floating-action-button.jsx the touch state is misspelled in touched.
oliviertassinari
added
PR: needs revision
| const FloatingActionButtonExampleSimple = () => ( | ||
| <div> | ||
| <FloatingActionButton> | ||
| <ToggleStar /> |
There was a problem hiding this comment.
What do you think about using a + icon instead of the star as it's the icon the most used in the google material spec website?
(What would apply to all the examples of the FloatingActionButton)
Zadielerick
force-pushed
the
buttonsDocsUpdate
branch
from
b4880a8
to
db86375
Compare
Zadielerick
force-pushed
the
buttonsDocsUpdate
branch
from
6584e7a
to
e53955d
Compare
|
We will have to do something about: |
|
I have tried to mess with the CSS, but can't get the button to move down... It seems to be because the linkButton renders a |
|
Ok so we have two differents issue:
|
|
@Zadielerick Thanks againt! |
Still need to fix a glitch with linkbutton prop messing up styles. Help is appreciated.