Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[docs] Polish jss-to-styled docs #27457

Merged
merged 2 commits into from
Jul 27, 2021
Merged

[docs] Polish jss-to-styled docs #27457

merged 2 commits into from
Jul 27, 2021

Conversation

oliviertassinari
Copy link
Member

It's a follow-up on #27292.

  • Add the missing instructions to use the codemod
  • Fix the warning grammar
  • Fix the git diff
  • Add dots to close the sentences
  • Cross-link migration guide and jss codemod

@oliviertassinari oliviertassinari added docs Improvements or additions to the documentation v5.x migration labels Jul 26, 2021
@mui-pr-bot
Copy link

mui-pr-bot commented Jul 26, 2021 •
edited
Loading

No bundle size changes (experimental)

Generated by 🚫 dangerJS against b17c412

@github-actions github-actions bot mentioned this pull request Jul 26, 2021
Closed
siriwatknp
siriwatknp approved these changes Jul 27, 2021
View reviewed changes
Copy link
Member

@siriwatknp siriwatknp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

only 1 suggestion, the rest looks good.

@oliviertassinari @siriwatknp
Fix link
b17c412 
Co-authored-by: Siriwat K <siriwatkunaporn@gmail.com>
@oliviertassinari oliviertassinari merged commit b33187a into mui:next Jul 27, 2021
@oliviertassinari oliviertassinari deleted the docs-jss-codemod branch July 27, 2021 09:41
@github-actions github-actions bot mentioned this pull request Jul 27, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@siriwatknp siriwatknp siriwatknp approved these changes

Assignees
No one assigned
Labels
docs Improvements or additions to the documentation v5.x migration
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@oliviertassinari @mui-pr-bot @siriwatknp