[Docs] Update Documentation for Lists #2782
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| <ListItem | ||
| primaryText="Brendan Lim" | ||
| leftAvatar={<Avatar src="images/ok-128.jpg" />} | ||
| rightIcon={<CommunicationChatBubble />} /> |
There was a problem hiding this comment.
<CommunicationChatBubble /> is repeated 6 times. The page is quite slow, can we create a
const communicationChatBubble = <CommunicationChatBubble />;outside of the render method?
There was a problem hiding this comment.
Edit, http://babeljs.io/docs/plugins/transform-react-constant-elements/ should do it for us, that's not needed 😄.
|
@Zadielerick Realy good work here 👍 👍! |
oliviertassinari
added
docs
|
@oliviertassinari Thanks! |
Zadielerick
force-pushed
the
listDocsUpdate
branch
from
f0bde64 to
8489ab1
Compare
| @@ -0,0 +1,41 @@ | |||
| ## Selectable List | |||
| Basically three steps are needed: | |||
| * enhance < List > with HOC | |||
There was a problem hiding this comment.
What about?
* enhance `List` with HOCAnd same for any occurrences of < XXX >
Zadielerick
force-pushed
the
listDocsUpdate
branch
from
6de8ec8 to
7e6b09a
Compare
29 tasks
oliviertassinari
added a commit
that referenced
this pull request
Jan 5, 2016
[Docs] Update Documentation for Lists
| import ListExampleFolders from './ExampleFolders.jsx'; | ||
| import listExampleNestedCode from '!raw!./ExampleNested.jsx'; | ||
| import ListExampleNested from './ExampleNested.jsx'; | ||
| //ExampleNested causes warning! |
There was a problem hiding this comment.
@Zadielerick Could you remove this line? 😁
There was a problem hiding this comment.
@oliviertassinari Yes sorry, could I do it in any other PR?
|
Sure. Thanks |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.