[Docs] Update Documentation for Paper #2797
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Zadielerick
force-pushed
the
paperDocsUpdate
branch
from
024de95 to
1a81b18
Compare
29 tasks
| import React from 'react'; | ||
| import Paper from 'material-ui/lib/paper'; | ||
|
|
||
| let style = { |
There was a problem hiding this comment.
const.
I plan to enforce the eslint prefer-const, that will help 😁.
Zadielerick
force-pushed
the
paperDocsUpdate
branch
from
1a81b18 to
916aebf
Compare
| textAlign: 'center', | ||
| display: 'inline-block', | ||
| }, | ||
| p: { |
There was a problem hiding this comment.
I'm not sure we need this <p> component, that make the examples less simple.
There was a problem hiding this comment.
Should it be better to not say anything inside the papers?
Zadielerick
force-pushed
the
paperDocsUpdate
branch
from
916aebf to
9a9f37b
Compare
oliviertassinari
added
docs
Zadielerick
force-pushed
the
paperDocsUpdate
branch
from
9a9f37b to
5f9f6e0
Compare
| const style = { | ||
| height: 100, | ||
| width: 100, | ||
| marginLeft: 40, |
There was a problem hiding this comment.
What about margin: 20 instead to fix (small screen)
Zadielerick
force-pushed
the
paperDocsUpdate
branch
from
5f9f6e0 to
2546d1f
Compare
| const style = { | ||
| height: 100, | ||
| width: 100, | ||
| marginLeft: 20, |
There was a problem hiding this comment.
not marginLeft, margin, so that the paper elements are not too close when they go to the next line 😁
Zadielerick
force-pushed
the
paperDocsUpdate
branch
from
2546d1f to
12bc19a
Compare
oliviertassinari
added
PR: Review Accepted
and removed
PR: needs revision
oliviertassinari
added a commit
that referenced
this pull request
Jan 6, 2016
[Docs] Update Documentation for Paper
|
@Zadielerick One more 🎉! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.