Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Docs] Update Documentation for Switches #2814

Closed
wants to merge 1 commit into from

Conversation

Zadielerick
Copy link
Contributor

Did not set defaultProps for checked or toggled because it messes up components.

const style = {
container: {
textAlign: 'left',
marginBottom: '16px',
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

marginBottom: 16,

@oliviertassinari oliviertassinari added docs Improvements or additions to the documentation PR: Needs Review labels Jan 6, 2016
import RadioButtonGroup from 'material-ui/lib/radio-button-group';

const style = {
container: {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Unused

@oliviertassinari oliviertassinari added PR: needs revision The pull request can't be merged. More details is available on the code review or fails in the CI and removed PR: Needs Review labels Jan 7, 2016
@@ -36,6 +86,13 @@ const Toggle = React.createClass({
StylePropable,
],

getDefaultProps() {
return {
defaultToggled: false,
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not sure it should be false by default. Maybe null.

@oliviertassinari
Copy link
Member

@Zadielerick Thanks again!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
docs Improvements or additions to the documentation PR: needs revision The pull request can't be merged. More details is available on the code review or fails in the CI
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants