Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[ButtonGroup] Support different elements under ButtonGroup #28645

Merged
merged 25 commits into from
Nov 2, 2021
Merged

[ButtonGroup] Support different elements under ButtonGroup #28645

merged 25 commits into from
Nov 2, 2021

Commits on Sep 24, 2021

  1. replace React.cloneElement with Context API in ButtonGroup for suppor… 

    …t different elements other than <Button />
    @ZeeshanTamboli
    ZeeshanTamboli committed Sep 24, 2021
    Configuration menu
    Copy the full SHA
    38c2624 View commit details
    Browse the repository at this point in the history

Commits on Sep 27, 2021

  1. use ButtonGroupContext in Button component

    @ZeeshanTamboli
    ZeeshanTamboli committed Sep 27, 2021
    Configuration menu
    Copy the full SHA
    abdc7e6 View commit details
    Browse the repository at this point in the history

  2. test: ButtonGroup context

    @ZeeshanTamboli
    ZeeshanTamboli committed Sep 27, 2021
    Configuration menu
    Copy the full SHA
    7bf3f2b View commit details
    Browse the repository at this point in the history

  3. test: ButtonGroup context

    @ZeeshanTamboli
    ZeeshanTamboli committed Sep 27, 2021
    Configuration menu
    Copy the full SHA
    b2a5904 View commit details
    Browse the repository at this point in the history

  4. yarn prettier

    @ZeeshanTamboli
    ZeeshanTamboli committed Sep 27, 2021
    Configuration menu
    Copy the full SHA
    b035d15 View commit details
    Browse the repository at this point in the history

Commits on Sep 28, 2021

  1. add types for ButtonGroupContext

    @ZeeshanTamboli
    ZeeshanTamboli committed Sep 28, 2021
    Configuration menu
    Copy the full SHA
    aa88456 View commit details
    Browse the repository at this point in the history

  2. Merge branch 'master' into issue/17226-support-different-elements-to-… 

    …ButtonGroup
    @ZeeshanTamboli
    ZeeshanTamboli committed Sep 28, 2021
    Configuration menu
    Copy the full SHA
    14a6172 View commit details
    Browse the repository at this point in the history

  3. yarn prettier

    @ZeeshanTamboli
    ZeeshanTamboli committed Sep 28, 2021
    Configuration menu
    Copy the full SHA
    3cbe153 View commit details
    Browse the repository at this point in the history

  4. yarn workspace framer build

    @ZeeshanTamboli
    ZeeshanTamboli committed Sep 28, 2021
    Configuration menu
    Copy the full SHA
    9f6dddb View commit details
    Browse the repository at this point in the history

Commits on Oct 6, 2021

  1. Merge branch 'master' into issue/17226-support-different-elements-to-… 

    …ButtonGroup
    @ZeeshanTamboli
    ZeeshanTamboli committed Oct 6, 2021
    Configuration menu
    Copy the full SHA
    3475901 View commit details
    Browse the repository at this point in the history

Commits on Oct 21, 2021

  1. Merge branch 'master' into issue/17226-support-different-elements-to-… 

    …ButtonGroup
    @ZeeshanTamboli
    ZeeshanTamboli committed Oct 21, 2021
    Configuration menu
    Copy the full SHA
    069e626 View commit details
    Browse the repository at this point in the history

Commits on Oct 22, 2021

  1. code review changes

    @ZeeshanTamboli
    ZeeshanTamboli committed Oct 22, 2021
    Configuration menu
    Copy the full SHA
    e07da28 View commit details
    Browse the repository at this point in the history

  2. yarn prettier

    @ZeeshanTamboli
    ZeeshanTamboli committed Oct 22, 2021
    Configuration menu
    Copy the full SHA
    b66656c View commit details
    Browse the repository at this point in the history

  3. test: pass props to ButtonGroup to test if it is received to Context … 

    …consumers
    @ZeeshanTamboli
    ZeeshanTamboli committed Oct 22, 2021
    Configuration menu
    Copy the full SHA
    3cd743d View commit details
    Browse the repository at this point in the history

  4. Merge branch 'master' into issue/17226-support-different-elements-to-… 

    …ButtonGroup
    @ZeeshanTamboli
    ZeeshanTamboli committed Oct 22, 2021
    Configuration menu
    Copy the full SHA
    5fa41eb View commit details
    Browse the repository at this point in the history

  5. fix cylic import

    @ZeeshanTamboli
    ZeeshanTamboli committed Oct 22, 2021
    Configuration menu
    Copy the full SHA
    3770a76 View commit details
    Browse the repository at this point in the history

Commits on Oct 26, 2021

  1. fix cyclic import

    @ZeeshanTamboli
    ZeeshanTamboli committed Oct 26, 2021
    Configuration menu
    Copy the full SHA
    d198923 View commit details
    Browse the repository at this point in the history

  2. Merge branch 'master' into issue/17226-support-different-elements-to-… 

    …ButtonGroup
    @ZeeshanTamboli
    ZeeshanTamboli committed Oct 26, 2021
    Configuration menu
    Copy the full SHA
    5989f53 View commit details
    Browse the repository at this point in the history

  3. use import type to avoid circular dependency

    @ZeeshanTamboli
    ZeeshanTamboli committed Oct 26, 2021
    Configuration menu
    Copy the full SHA
    e1e6657 View commit details
    Browse the repository at this point in the history

Commits on Oct 28, 2021

  1. change destructuring default values syntax to support JSDoc @default … 

    …annotation
    @ZeeshanTamboli
    ZeeshanTamboli committed Oct 28, 2021
    Configuration menu
    Copy the full SHA
    e255ea2 View commit details
    Browse the repository at this point in the history

  2. fix(Button): disableRipple default value

    @ZeeshanTamboli
    ZeeshanTamboli committed Oct 28, 2021
    Configuration menu
    Copy the full SHA
    8c4ca0d View commit details
    Browse the repository at this point in the history

  3. fix(Button): initialize button props which may have context values or… 

    … default values
    @ZeeshanTamboli
    ZeeshanTamboli committed Oct 28, 2021
    Configuration menu
    Copy the full SHA
    f5f4c2a View commit details
    Browse the repository at this point in the history

Commits on Nov 2, 2021

  1. Merge branch 'master' into issue/17226-support-different-elements-to-… 

    …ButtonGroup
    @ZeeshanTamboli
    ZeeshanTamboli committed Nov 2, 2021
    Configuration menu
    Copy the full SHA
    2773bf9 View commit details
    Browse the repository at this point in the history

  2. add TODO comment

    @ZeeshanTamboli
    ZeeshanTamboli committed Nov 2, 2021
    Configuration menu
    Copy the full SHA
    6b739f4 View commit details
    Browse the repository at this point in the history

  3. yarn prettier

    @ZeeshanTamboli
    ZeeshanTamboli committed Nov 2, 2021
    Configuration menu
    Copy the full SHA
    1c026b8 View commit details
    Browse the repository at this point in the history