Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[docs] Remove legacy team page #28646

Merged
merged 4 commits into from
Sep 29, 2021

Conversation

mnajdova
Copy link
Member

@mnajdova mnajdova commented Sep 27, 2021

One of #27825

Removes the legacy team page and adds a redirect from the old one to the new about us page.

Preview link: https://deploy-preview-28646--material-ui.netlify.app/

image

@@ -326,7 +326,6 @@ const pages: readonly MuiPage[] = [
{ pathname: '/discover-more/roadmap' },
{ pathname: '/discover-more/backers', title: 'Sponsors & Backers' },
{ pathname: '/discover-more/vision' },
{ pathname: '/discover-more/team' },
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should we instead of removing this add a link to the About us page? cc @danilo-leal @oliviertassinari

Copy link
Member

@oliviertassinari oliviertassinari Sep 27, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Or, maybe it makes sense to keep the team section, one per product, e.g. https://reactjs.org/community/team.html. We could add one for MUI X, once we split the docs. No real preferences.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That would be even better. I like their short bio for each member 😄 But for now, maybe a link to the About us page would be enough. Feels weird to have it only on the landing page.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The team section on the About page is company-wide, which works for now. Whenever and if we split the docs, having one per product is indeed a nice thing because people can reach out to the specific team members that maintain Core, X, and so on. :)

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Alright, will add it and leave this open for future reference

Copy link
Member

@oliviertassinari oliviertassinari Sep 28, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

So to be clear, from what I understand, the plan is to:

  1. remove the current page duplication (this PR)
  2. add the team pages back once its clearer in the docs that we have different products, one per product/team cc @mui-org/x

It sounds great

docs/public/_redirects Outdated Show resolved Hide resolved
@@ -326,7 +326,6 @@ const pages: readonly MuiPage[] = [
{ pathname: '/discover-more/roadmap' },
{ pathname: '/discover-more/backers', title: 'Sponsors & Backers' },
{ pathname: '/discover-more/vision' },
{ pathname: '/discover-more/team' },
Copy link
Member

@oliviertassinari oliviertassinari Sep 27, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Or, maybe it makes sense to keep the team section, one per product, e.g. https://reactjs.org/community/team.html. We could add one for MUI X, once we split the docs. No real preferences.

Copy link
Member

@eps1lon eps1lon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

CI is red

Co-authored-by: Olivier Tassinari <olivier.tassinari@gmail.com>
@mui-pr-bot
Copy link

mui-pr-bot commented Sep 28, 2021

No bundle size changes

Generated by 🚫 dangerJS against 925f4d4

Copy link
Contributor

@danilo-leal danilo-leal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me!

@oliviertassinari oliviertassinari added the docs Improvements or additions to the documentation label Sep 28, 2021
@mnajdova mnajdova merged commit b697728 into mui:master Sep 29, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
docs Improvements or additions to the documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants