-
-
Notifications
You must be signed in to change notification settings - Fork 32.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[docs] Remove legacy team page #28646
Conversation
@@ -326,7 +326,6 @@ const pages: readonly MuiPage[] = [ | |||
{ pathname: '/discover-more/roadmap' }, | |||
{ pathname: '/discover-more/backers', title: 'Sponsors & Backers' }, | |||
{ pathname: '/discover-more/vision' }, | |||
{ pathname: '/discover-more/team' }, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should we instead of removing this add a link to the About us page? cc @danilo-leal @oliviertassinari
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Or, maybe it makes sense to keep the team section, one per product, e.g. https://reactjs.org/community/team.html. We could add one for MUI X, once we split the docs. No real preferences.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
That would be even better. I like their short bio for each member 😄 But for now, maybe a link to the About us page would be enough. Feels weird to have it only on the landing page.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The team section on the About page is company-wide, which works for now. Whenever and if we split the docs, having one per product is indeed a nice thing because people can reach out to the specific team members that maintain Core, X, and so on. :)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Alright, will add it and leave this open for future reference
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
So to be clear, from what I understand, the plan is to:
- remove the current page duplication (this PR)
- add the team pages back once its clearer in the docs that we have different products, one per product/team cc @mui-org/x
It sounds great
@@ -326,7 +326,6 @@ const pages: readonly MuiPage[] = [ | |||
{ pathname: '/discover-more/roadmap' }, | |||
{ pathname: '/discover-more/backers', title: 'Sponsors & Backers' }, | |||
{ pathname: '/discover-more/vision' }, | |||
{ pathname: '/discover-more/team' }, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Or, maybe it makes sense to keep the team section, one per product, e.g. https://reactjs.org/community/team.html. We could add one for MUI X, once we split the docs. No real preferences.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
CI is red
Co-authored-by: Olivier Tassinari <olivier.tassinari@gmail.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me!
One of #27825
Removes the legacy team page and adds a redirect from the old one to the new about us page.
Preview link: https://deploy-preview-28646--material-ui.netlify.app/