Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[docs] Add to migration doc about ref type specificity #30114

Merged
merged 6 commits into from
Dec 17, 2021
Merged

[docs] Add to migration doc about ref type specificity #30114

merged 6 commits into from
Dec 17, 2021

Conversation

hbjORbj
Copy link
Member

@hbjORbj hbjORbj commented Dec 8, 2021

Closes #27993

@hbjORbj hbjORbj requested a review from mnajdova December 8, 2021 13:17
@mui-pr-bot
Copy link

mui-pr-bot commented Dec 8, 2021 •
edited
Loading

No bundle size changes

Generated by 🚫 dangerJS against fe4ed72

@hbjORbj hbjORbj added the docs Improvements or additions to the documentation label Dec 8, 2021
mnajdova
mnajdova reviewed Dec 16, 2021
View reviewed changes
docs/src/pages/guides/migration-v4/migration-v4.md Outdated

##### `@mui/material`

- [Accordion](/components/accordion)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's list next to each component what type of element it expects, for example HTMLLIElement or HTMLDivElement etc.

mnajdova
mnajdova approved these changes Dec 16, 2021
View reviewed changes
Copy link
Member

@mnajdova mnajdova left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👌 thanks Benny

siriwatknp
siriwatknp approved these changes Dec 17, 2021
View reviewed changes
Copy link
Member

@siriwatknp siriwatknp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 Good one.

@hbjORbj hbjORbj merged commit 830b424 into mui:master Dec 17, 2021
@oliviertassinari oliviertassinari mentioned this pull request Dec 23, 2021
Merged
oliviertassinari
oliviertassinari reviewed Dec 25, 2021
View reviewed changes
docs/src/pages/guides/migration-v4/migration-v4.md

The list of components that expect a specific element type is as follows:

##### `@mui/material`
Copy link
Member

@oliviertassinari oliviertassinari Dec 25, 2021 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The heading level is wrong, the previous one is h3, this one h5

Suggested change
##### `@mui/material`
#### `@mui/material`

@oliviertassinari oliviertassinari mentioned this pull request Dec 25, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@oliviertassinari oliviertassinari oliviertassinari left review comments

@mnajdova mnajdova mnajdova approved these changes

@siriwatknp siriwatknp siriwatknp approved these changes

Assignees
No one assigned
Labels
docs Improvements or additions to the documentation
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[docs] Mention about ref type specificity in migration to v5 doc
5 participants
@hbjORbj @mui-pr-bot @oliviertassinari @mnajdova @siriwatknp