-
-
Notifications
You must be signed in to change notification settings - Fork 32.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[docs] Fix crash on Safari because of unsupported lookahead feature #30345
Conversation
I have tried to push the approach further, describing why we have this logic. From what I understand, from an end-user perspective, to mitigate for the first 60 minutes that the crawl index is not up to date, which will lead to people having a 301. From a maintainer perspective, it's about being able to use the search with this feature flag enable. |
@siriwatknp Are you happy with this fix? |
@cherniavskii @oliviertassinari thank you so much for the fix. However, I decided to change the migration strategy to another way without replacing the I am closing this PR and remove the logic in #30386 |
@siriwatknp Will #30386 be merged before the next release? If there is a chance that it won't, I would suggest that we have a standalone PR to avoid a regression in production once we release HEAD. Currently, HEAD is broken, and production has a hotfix. |
@oliviertassinari good point, maybe reopen and continue on this PR is better. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍 Thanks for the fix! I have added more tests.
@siriwatknp Perfect thanks |
Fixes #30344
I've followed steps in described in
Review suggestion
#30107 to runtest:e2e-website:dev
, but relevant tests kept failing for some reason (even before my changes).Let me know if there's something missing in the PR.