[docs] More general docs polishing #30371
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@oliviertassinari I tried to act on all comments you left on the previous polishment PR. Also, as I changed the styling customization of the Menu to the theme, rather than using the |
danilo-leal
added
the
website
17 tasks
github-actions
bot
added
the
PR: out-of-date
github-actions
bot
removed
the
PR: out-of-date
1 task
siriwatknp
reviewed
Dec 27, 2021
| @@ -38,10 +38,10 @@ const Tab = styled(TabUnstyled)` | |||
| background-color: ${blue[400]}; | |||
| } | |||
|
|
|||
| &.${buttonUnstyledClasses.focusVisible} { | |||
There was a problem hiding this comment.
Don't we encourage the community to use focusVisible? cc @michaldudak
There was a problem hiding this comment.
I changed to only &:focus because using the focusVisible class wasn't working 😕 The styles weren't being applied to the component when focused. Not sure if it's really a problem or just me not knowing how to work on it.
siriwatknp
approved these changes
Dec 28, 2021
wladimirguerra
pushed a commit
to wladimirguerra/material-ui
that referenced
this pull request
Feb 2, 2022
Co-authored-by: siriwatknp <siriwatkunaporn@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Following up on some left-overs from the previous PR (as suggested) while enjoying the time to tweak some stuff a bit more:
theme.typography.fontWeightMediumto use the plain weight500.sxprop so I moved it all to the theme.Deploy previews: