Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[l10n] Improve fi-FI locale #30442

Merged
merged 1 commit into from
Dec 29, 2021
Merged

[l10n] Improve fi-FI locale #30442

merged 1 commit into from
Dec 29, 2021

Conversation

vuoriva
Copy link
Contributor

@vuoriva vuoriva commented Dec 29, 2021

Originally, I was planning to only include one option but upon seeing how the change would look in an actual table I came up with two possible solutions since the Finnish language does not have a similar word as "of" in English:

  • First (currently in the PR and more line with rest of the languages' style):

image

  • Second (aesthetically more pleasing since at no other positions of the string are words used):

image

Any comments and/or discussion regarding the topic is welcome.

@mui-pr-bot
Copy link

mui-pr-bot commented Dec 29, 2021

No bundle size changes

Generated by 🚫 dangerJS against d243d6a

@oliviertassinari oliviertassinari changed the title [i18n]: Improve fiFI locale [l10n] Improve fiFI locale Dec 29, 2021
@oliviertassinari oliviertassinari added the l10n localization label Dec 29, 2021
@oliviertassinari oliviertassinari merged commit d3c609b into mui:master Dec 29, 2021
@oliviertassinari
Copy link
Member

@Certificate Thanks

@oliviertassinari oliviertassinari changed the title [l10n] Improve fiFI locale [l10n] Improve fi-FI locale Dec 29, 2021
@vuoriva vuoriva deleted the patch-1 branch December 30, 2021 10:18
wladimirguerra pushed a commit to wladimirguerra/material-ui that referenced this pull request Feb 2, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
l10n localization
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants