[Joy] Add Typography component
#30489
Conversation
|
@mui/joy: parsed: +2.24% , gzip: +2.04% |
| }, | ||
| })<{ ownerState: TypographyProps }>(({ theme, ownerState }) => ({ | ||
| margin: 0, | ||
| // TODO: remove in the next major version |
There was a problem hiding this comment.
What next version do these TODOs refer to? As we're building the first version, we can introduce breaking changes (vs material) now, can't we?
There was a problem hiding this comment.
Yeah, I also doubt my initial thought. @danilo-leal What do you think? should we go with only level prop or leave it like this and revisit again before the official release?
There was a problem hiding this comment.
It doesn't make too much sense to me to maintain @mui/material props in any Joy component for the sake of ease of transition. They're meant to be different things with different stakes/trade-offs (at least at some levels), so I'd go for breaking away from Material when appropriate from the get-go.
| inherit: 'p', | ||
| }; | ||
|
|
||
| const Typography = React.forwardRef(function Typography(inProps, ref) { |
There was a problem hiding this comment.
Side note: I'm wondering why don't we just call it Text - it's much shorter to type :)
There was a problem hiding this comment.
I don't want to change the component name at this point but I think @oliviertassinari can explain the history of "Typography".
Co-authored-by: Michał Dudak <michal.dudak@gmail.com> Co-authored-by: Benny Joo <sldisek783@gmail.com>
github-actions
bot
added
the
PR: out-of-date
github-actions
bot
removed
the
PR: out-of-date
oliviertassinari
added
component: Typography
Summary
Mostly replicate material Typography component with some deprecations:
variantto uselevelprop instead (variant has another meaning in Joy)alignandparagraphprop because ofsxprop.The intention of deprecation instead of removing is to ease people who are familiar with
material(To be honest, I am a bit reluctant about this decision, waiting to see the team's thought)