[docs] Fix the crash when applying custom colors #30563
Conversation
| ...brandingDesignTokens.palette, | ||
| ...paletteColors, |
There was a problem hiding this comment.
This is the root cause. the whole primary which contains only main property replace the branding color (50-900) are gone. So it causes the crash in some part that tries to use alpha(...500).
There was a problem hiding this comment.
Interesting, I wonder if we shouldn't push it further, by only updating the demos, leaving the rest of the docs unchanged. I have noticed a couple of cases that are weird when setting the colors to red:
- Partially colored links:
- Partially colored sidenav:
| primary: { main: outerTheme.palette.primary.main }, | ||
| secondary: { main: outerTheme.palette.secondary.main }, |
There was a problem hiding this comment.
Need to change to this so that light and dark are recalculated based on the main color.
hbjORbj
added
docs
|
Could we publish this ASAP please? Two more reports today, so presumably many more users affected. |
| ...brandingDesignTokens.palette, | ||
| ...paletteColors, |
There was a problem hiding this comment.
Interesting, I wonder if we shouldn't push it further, by only updating the demos, leaving the rest of the docs unchanged. I have noticed a couple of cases that are weird when setting the colors to red:
- Partially colored links:
- Partially colored sidenav:
🔗 https://deploy-preview-30563--material-ui.netlify.app/customization/color/#playground
close #30343