-
-
Notifications
You must be signed in to change notification settings - Fork 32.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[website] Fix code button with installation command #30622
Conversation
A question I have though: due to the limited space and me not wanting to break the overall layout (two buttons in a row), the command is not entirely visible (even though it is copied in its entirety when the button is clicked). Could that be a problem or a confusing thing? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍 LGTM
I don't know how the commits regarding the logo improvements ended up in this PR... Reversing them.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The Get Started link target is definitely an improvement! 👍
As for the installation command, I liked the previous version better, but it's nowhere near a hill I'm willing to die on ;)
It seems to introduce another problem: |
I've addressed it in #30828. |
@danilo-leal Great, thanks |
Hopefully fixes #30585.
Get started
button now directs to the Installation page instead of the Usage.https://deploy-preview-30622--material-ui.netlify.app/