[useMediaQuery] Ensure no tearing in React 18 #30655
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
eps1lon
changed the title
|
@material-ui/core: parsed: +0.10% , gzip: +0.13% |
michaldudak
reviewed
Jan 25, 2022
There was a problem hiding this comment.
Thanks for working on this! Could you please rebase on the latest master and solve the build errors?
@mnajdova, @siriwatknp you may want to take a look at it as well.
hbjORbj
force-pushed
the
feat/useMediaQuery/uSES
branch
from
1467ddf to
07ef237
Compare
Benny rebased now so this should be fine. For build errors, please see the PR description: They are expected for the React 18 pipeline where failures only related to |
michaldudak
approved these changes
Jan 25, 2022
wladimirguerra
pushed a commit
to wladimirguerra/material-ui
that referenced
this pull request
Feb 2, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Restores #28491 which was reverted in #29870 by using a workaround described in webpack/webpack#14814 (comment).
Failed checks are from the React 18 run and just
git diff --exit-codewhich is expected.@mui/material@5.2.0(which is not using the workaround linked above).