Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[FormControlLabel][FormGroup] add Mui-error class #30656

Merged
merged 6 commits into from
Jan 26, 2022
Merged

[FormControlLabel][FormGroup] add Mui-error class #30656

merged 6 commits into from
Jan 26, 2022

Conversation

alisasanib
Copy link
Contributor

@alisasanib alisasanib commented Jan 16, 2022 •
edited
Loading

Fixes: #30576

demo

Problem:

  • FormControlLabel and FormGroup components did not inherit the Mui-error class

Solution:

  • Adding Mui-error className option based on the FormControl to these two components

@mui-bot
Copy link

mui-bot commented Jan 16, 2022 •
edited
Loading

Details of bundle changes

Generated by 🚫 dangerJS against df377d3

mnajdova
mnajdova reviewed Jan 17, 2022
View reviewed changes
Copy link
Member

@mnajdova mnajdova left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes look good, let's add tests

@mnajdova mnajdova added component: text field This is the name of the generic UI component, not the React module! PR: needs test The pull request can't be merged labels Jan 17, 2022
@alisasanib alisasanib requested a review from mnajdova January 17, 2022 13:29
@alisasanib
Copy link
Contributor Author

@mnajdova thanks for the comment. I just added the tests for FormGroup and FormControlLabel to check their error classes.

mnajdova
mnajdova approved these changes Jan 26, 2022
View reviewed changes
Copy link
Member

@mnajdova mnajdova left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Perfect, thanks!

@mnajdova mnajdova merged commit fce6e59 into mui:master Jan 26, 2022
@alisasanib alisasanib deleted the FormControlLabel-FormGroup/add-error-class branch January 26, 2022 13:54
wladimirguerra pushed a commit to wladimirguerra/material-ui that referenced this pull request Feb 2, 2022
@alisasanib @wladimirguerra
[FormControlLabel][FormGroup] add Mui-error class (mui#30656)
6e96e20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mnajdova mnajdova mnajdova approved these changes

Assignees
No one assigned
Labels
component: text field This is the name of the generic UI component, not the React module! PR: needs test The pull request can't be merged
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

No Mui-error class (error state) with FormGroup and FormControlLabel
3 participants
@alisasanib @mui-bot @mnajdova