Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[core] Batch small changes #30690

Merged
merged 6 commits into from
Jan 19, 2022

Conversation

oliviertassinari
Copy link
Member

@oliviertassinari oliviertassinari commented Jan 18, 2022

@oliviertassinari oliviertassinari added the core Infrastructure work going on behind the scenes label Jan 18, 2022
@mui-bot
Copy link

mui-bot commented Jan 18, 2022

No bundle size changes

Generated by 🚫 dangerJS against 1ac7945

@@ -5757,7 +5757,7 @@ Here are some highlights ✨:
Last but not least, the change allows us to take advantage dynamic style props. We will use them for dynamic color props, variant props, and new style props (an improved [system](https://mui.com/system/basics/)).

This change has been in our roadmap for more than a year.
We announced it in the [v4 release blog post](https://medium.com/material-ui/material-ui-v4-is-out-4b7587d1e701) as a direction v5 would take.
We announced it in the [v4 release blog post](https://mui.com/blog/material-ui-v4-is-out/) as a direction v5 would take.
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a follow-up to #30121

@@ -43,7 +43,7 @@ Here are some recommended resources, some of which are free.

- **Implement high fidelity designs**: Bridge the gap between Design & Development. Break down detailed designs and bring them to life with MUI and React.

- 💻 [The Course](https://click.linksynergy.com/deeplink?id=IVuPfk1F/Ow&mid=39197&murl=https%3A%2F%2Fwww.udemy.com%2Fcourse%2Fimplement-high-fidelity-designs-with-material-ui-and-reactjs%2F)
- 💻 [The Course](https://www.udemy.com/course/implement-high-fidelity-designs-with-material-ui-and-reactjs/)
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This legacy affiliation link with Rakuten slows the navigation down.

@@ -106,6 +106,9 @@ https://v4.material-ui.com/* https://v4.mui.com/:splat 301!
/discover-more/team/ /about/ 301
/api/data-grid/grid-export-csv-options/ /api/data-grid/grid-csv-export-options/ 301

# 2022
/company/about/ /about/ 301
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I noticed this looking at #30608. I removed the content. Oops https://mui.com/company/about/

@danilo-leal
Copy link
Contributor

Used this PR to push small changes to a few things, most notably hiding the Designer job ad while it isn't open 😅

@oliviertassinari oliviertassinari merged commit 5e3d995 into mui:master Jan 19, 2022
@oliviertassinari oliviertassinari deleted the batch-small-changes-v2 branch January 19, 2022 11:55
wladimirguerra pushed a commit to wladimirguerra/material-ui that referenced this pull request Feb 2, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
core Infrastructure work going on behind the scenes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants