Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[docs] Fix migration issues detected by ahrefs #30751

Merged
merged 12 commits into from
Jan 24, 2022
Merged

[docs] Fix migration issues detected by ahrefs #30751

merged 12 commits into from
Jan 24, 2022

Conversation

siriwatknp
Copy link
Member

@siriwatknp siriwatknp commented Jan 24, 2022 •
edited
Loading

Issues

Issues found in https://app.ahrefs.com/site-audit/3276941/1/crawl-log

  • /zh/material/* has TOC link as undefined at the end
  • /zh/material/* still use old pages config (it should use the new pages data)
  • wrong Regex which transform image-lists to react-image-lit (should be react-image-list)
  • API tabs-list-unstyled contains /material instead of /base
  • API page link to /material/react-icon instead of /material/icons
  • Base components (NoSSR, Portal, and TextareaAutosize) without Unstyled name point to /material/api instead of /base/api

The above issues are fixed with tests, will merge once CIs are green (the x repo also need this PR)

@siriwatknp siriwatknp changed the title [docs] Fix migration issues [docs] Fix migration issues detected by ahrefs Jan 24, 2022
@mui-bot
Copy link

mui-bot commented Jan 24, 2022 •
edited
Loading

No bundle size changes

Generated by 🚫 dangerJS against 320502b

mnajdova
mnajdova approved these changes Jan 24, 2022
View reviewed changes
Copy link
Member

@mnajdova mnajdova left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes look good

@siriwatknp siriwatknp merged commit 4074de7 into mui:master Jan 24, 2022
@oliviertassinari oliviertassinari added the docs Improvements or additions to the documentation label Jan 24, 2022
wladimirguerra pushed a commit to wladimirguerra/material-ui that referenced this pull request Feb 2, 2022
@siriwatknp @wladimirguerra
[docs] Fix migration issues detected by ahrefs (mui#30751)
2142c71
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mnajdova mnajdova mnajdova approved these changes

Assignees
No one assigned
Labels
docs Improvements or additions to the documentation
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@siriwatknp @mui-bot @mnajdova @oliviertassinari