Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[test] Fix tests on Node 16 #30819

Merged
merged 1 commit into from
Jan 31, 2022
Merged

Conversation

michaldudak
Copy link
Member

Node 16 changed the error message associated with reading a property of a null reference.
This PR adds logic to detect node version and assert on the correct error message.

@mui-bot
Copy link

mui-bot commented Jan 28, 2022

No bundle size changes

Generated by 🚫 dangerJS against a5f726f

Copy link
Member

@oliviertassinari oliviertassinari left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice 👌

@oliviertassinari oliviertassinari added the component: autocomplete This is the name of the generic UI component, not the React module! label Jan 28, 2022
@michaldudak michaldudak merged commit 1e9bf52 into mui:master Jan 31, 2022
@michaldudak michaldudak deleted the node-16-error-message branch January 31, 2022 09:48
wladimirguerra pushed a commit to wladimirguerra/material-ui that referenced this pull request Feb 2, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component: autocomplete This is the name of the generic UI component, not the React module! test
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants