-
-
Notifications
You must be signed in to change notification settings - Fork 32.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[blog] Simplify the labels #30921
[blog] Simplify the labels #30921
Conversation
84af4d9
to
dbd09d9
Compare
@@ -13,7 +13,7 @@ export interface BlogPost { | |||
title: string; | |||
description: string; | |||
image?: string; | |||
tags?: Array<string>; | |||
tags: Array<string>; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
force to always have tags
docs/lib/sourcing.ts
Outdated
@@ -30,6 +30,10 @@ export const getBlogPost = (filePath: string): BlogPost => { | |||
}; | |||
}; | |||
|
|||
// Avoid typos in the blog markdown pages. | |||
// https://www.notion.so/mui-org/Blog-247ec2bff5fa46e799ef06a693c94917 | |||
const ALLOWED_TAGS = ['MUI Core', 'News', 'MUI X', 'Company', 'All products']; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
headers.components = []; | ||
return headers; | ||
} catch (err) { | ||
throw new Error(`${err.message} in getHeader(markdown) with markdown: \n\n${header}`); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@@ -4,7 +4,7 @@ description: We are excited to share that Danail Hadjiatanasov has joined MUI as | |||
date: 2020-10-23T00:00:00.000Z | |||
authors: ['oliviertassinari'] | |||
card: true | |||
tags: ['Team'] | |||
tags: ['Company', 'MUI X', 'News'] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Something's off with the logic, "All products" is returning posts that aren't tagged with it: But I'm not sure if "All products" is even necessary. Posts that cover both MUI X and Core simply need both those tags. Also, I'm not sure about tagging hiring posts with the product tag. If I select "MUI X" I expect posts about MUI X, not company news. |
It also feels like anything tagged "Company" should also be tagged "News", but that isn't currently always the case. |
ab249ca
to
116acae
Compare
@mbrookes It returns blog posts that have any of the product tags. Based on this logic, it works as expected. Now, is the expectation clear? This is another problem. The purpose of the tag is to be able to remove posts that don't cover the product, typically posts about the company, e.g. retreat, Material-UI -> MUI org rename, fundraising announcement. There might not be a lot.
My assumption is that we will get more than these two product labels. But we would also get: MUI Studio, MUI Base, MUI Design kits, etc. So that we would need some way to have a hierarchy of product labels.
I feel you. I have been torn internally about this problem. I went for a different approach: What I want to reproduce is this UX: https://www.hashicorp.com/blog/products/packer, for each product. We need to label each blog post for this. What I would argue is that Damien joining the MUI X team is about MUI X. The audience that cares about MUI X would want to know they is a new maintainer (back then, with a small team it mattered, now, less). No objections to removing this label though.
I'm happy with removing the "News" label if we can't get a common understanding of what this label is about => most people won't either => useless. Please advise. |
It's titled 'Posts tagged as "All products"', but returns posts that aren't tagged as "All products", so it's illogical, and doesn't work as expected. Tags have an implicitly understood behaviour, which this is breaking. It leads to poor UX. I'd vote to get rid of the "All products tag". Realistically, visitors will be interested in a particular product.
Deal.
I would assume that anything about the company is news, but not all news is about the company. |
My thoughts on the current state:
|
I have pushed a new commit that implements @samuelsycamore's ideas. It's doing the synthesis between:
We can add an "Engineering" tag in the future if we struggle to hire but considering our product, I doubt it. It would be used for blog posts like https://stripe.com/blog/globe or the one we have in #28362. Maybe more for fun.
It seems to be a great synthesis of the concerns that everyone has.
@mbrookes IMHO, the year in review is not really news. We usually don't announce anything new.
@danilo-leal The downside is that it's much longer. I have seen it used in https://www.netlify.com/blog/news/. A side thought: https://www.netlify.com/blog/2021/12/31/serving-custom-http-headers/ I think that this is crap. Spent the same amount of time to polish the docs, you will be way better off. Or create a proper tutorial, not a blog post! |
Looks good to me! I like the |
Potentially. For now, it's a dead property. I think that it's with the studio that we will really feel the pain, enough to make us want to have isolation. |
I wonder if using |
@danilo-leal the only issue I see there is that a |
Unless I'm missing something, Sam hadn't commented before this?
Then let's do what @danilo-leal and I suggested, and remove it in favour of the product specific ones.
But the quarterly reviews are? |
@mbrookes We have chatted about it during a meeting.
@mbrookes Yes, already removed 👍 .
@mbrookes We announce the latest features that were released in the quarterly blog posts and what will come next. Hence why I thought about it. Maybe we should have this strategy: always apply "News" unless it's obvious that it's not a news or an announcement (https://www.notion.so/mui-org/Blog-247ec2bff5fa46e799ef06a693c94917). Would this work? It would still solve the main problem: make it possible to filter out SEO evergreen blog posts. |
No, it has been renamed "Product" and the logic fixed. The product specific ones have been removed. It's the opposite of what @danilo-leal and I suggested.
It's the same in the annual blog post: 2021 in review and beyond. Either all of them are news, or none of them are.
As long as it's consistent. |
04fa5c5
to
35d1407
Compare
35d1407
to
4295cb5
Compare
So it seems that there is no agreement on the right way to handle these tags. At least, it's not clear to me what each person envisions as the best nor why. Therefore, I have reduced the ambition of this PR to unlock it. I have followed what seems to be an overall consensus. The baseline assumption is that a low number of tags = better. It's better because it improves the UX, because it's less operational overhead. Based on this assumption, there is a quick-win: "Company updates" and "Team" are about the company, so we can rename both to "Company". Does it work, can we merge? Thinking more about this problem, I have noticed something wrong with our terminology. What we have implemented as "tags" with the filtering is AFAIK normally called "categories"(I assume dating pre-WordPress). https://www.oncrawl.com/oncrawl-seo-thoughts/optimise-blog-categories-tags/ goes into more detail about why. They are meant to create horizontal cross-categories links, while categories are meant to create a vertical structure for readers to quickly filter out content. @samuelsycamore I would speak under your control, is this accurate? I have made a proposal in https://www.notion.so/mui-org/Blog-SEO-structure-897c1ad742ec4274838a10f4bd6b3e3a for what I think we should do next. Please challenge, or create alternative options.
@mbrookes I don't feel the same way about it. The quarter update covers changes with a 3 months lense, the yearly update achieves the same with a one-year lense. The former is x4 lot more granular about the recent past and close future than the latter. In practice, it means that quarterly blog posts can do announcements, while the yearly review focuses more on the past, it's a review. What I have felt is that we miss a https://mui.com/blog/2021-q4-update/ blog post. But it's not important. |
Bump |
This is an attempt to improve the blog post labels structure. I have documented in https://www.notion.so/mui-org/Blog-247ec2bff5fa46e799ef06a693c94917 was could make sense for 1. when to use each label so authors know what to apply and 2. why we have these labels, so we know how to change them.
We do the following simplification
https://deploy-preview-30921--material-ui.netlify.app/blog/
A side note: the pagination should be using
<a>
, not buttons. This is really important for SEO. Each post should be crawlable