Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Portal] Re-export 'Portal' in material #31003

Merged
merged 2 commits into from
Feb 10, 2022

Conversation

liradb2000
Copy link
Contributor

@liradb2000 liradb2000 commented Feb 10, 2022

Recently #30853 is pushed and applied version 5.4.x.

However, Portal Component is missing and can't access the component.

In #30853 PR,

Note: utility components, such as ClickAwayListener, NoSsr, Portal, and TextareaAutosize continue to be exported from both @mui/material and @mui/base

This PR is a re-export Portal Component and can access the Component without '@mui/base' package.

// package/mui-material/src/index.js
...
export * from './Popper';

+ export { default as Portal } from './Portal';
+ export * from './Portal';
+
export { default as Radio } from './Radio';
...
// package/mui-material/src/index.d.ts
...
export * from './Popper';

+ export { default as Portal } from './Portal';
+ export * from './Portal';
+
export { default as Radio } from './Radio';
...

@mui-bot
Copy link

mui-bot commented Feb 10, 2022

Details of bundle changes

Generated by 🚫 dangerJS against 7567f47

@michaldudak michaldudak changed the title [Portal]Re-export 'Portal' in material [Portal] Re-export 'Portal' in material Feb 10, 2022
@michaldudak michaldudak added component: Portal The React component. package: material-ui Specific to @mui/material labels Feb 10, 2022
Copy link
Member

@michaldudak michaldudak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We must have missed it. Thanks for the fix!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug 🐛 Something doesn't work component: Portal The React component. package: material-ui Specific to @mui/material regression A bug, but worse
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants