Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[docs] Update installation guide of the icons package #31026

Merged
merged 3 commits into from
Feb 14, 2022

Conversation

huyenltnguyen
Copy link
Contributor

The documentation of the icons package mentions that we need to install MUI in order to use it. However, the MUI installation command is missing @emotion/react and @emotion/styled. Instead of adding them to the command, I replaced the command with the link to the MUI installation guide so that we won't have to keep the two guides in-sync.

@mui-bot
Copy link

mui-bot commented Feb 11, 2022

No bundle size changes

Generated by 🚫 dangerJS against f35b409

@danilo-leal danilo-leal added the docs Improvements or additions to the documentation label Feb 11, 2022
Copy link
Contributor

@danilo-leal danilo-leal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome! Thanks for contributing, much better :)

Co-authored-by: Olivier Tassinari <olivier.tassinari@gmail.com>
Co-authored-by: Olivier Tassinari <olivier.tassinari@gmail.com>
@michaldudak michaldudak merged commit b187792 into mui:master Feb 14, 2022
@huyenltnguyen huyenltnguyen deleted the docs/installation branch February 14, 2022 13:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
docs Improvements or additions to the documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants